Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update project to use something like https://golang.cafe/blog/golang-functional-options-pattern.html to help with server configuration #94

Closed
raj3k opened this issue Jan 18, 2024 · 10 comments · Fixed by #147
Labels
api Improvements or additions to the api enhancement New feature or request go Language: Go

Comments

@raj3k
Copy link
Collaborator

raj3k commented Jan 18, 2024

Is your feature request related to a problem? Please describe.

No

Describe the solution you'd like

Refactor current server configuration. Currently there is small number of configurational parameters but when this number will raise, using f.e. Options Pattern could be beneficial.

Describe alternatives you've considered

N/a

Additional context

https://golang.cafe/blog/golang-functional-options-pattern.html
or
https://github.com/eddycjy/go-gin-example/blob/master/main.go

@raj3k raj3k added the enhancement New feature or request label Jan 18, 2024
@kevinanielsen
Copy link
Owner

I like this a lot - Would you like to work on this? @raj3k

@kevinanielsen kevinanielsen added api Improvements or additions to the api go Language: Go labels Jan 19, 2024
@raj3k
Copy link
Collaborator Author

raj3k commented Jan 19, 2024

@kevinanielsen yes, i will work on that

@kevinanielsen
Copy link
Owner

Perfect - Assigning you now!

@josefmay
Copy link

Is this feature request being actively worked on? If not, I would like to work on it.

@kevinanielsen
Copy link
Owner

@josefmay I believe it is not, I can assign you to it now :)

@kevinanielsen kevinanielsen assigned josefmay and unassigned raj3k Jul 1, 2024
@kevinanielsen
Copy link
Owner

Is this feature request being actively worked on? If not, I would like to work on it.

Any update on this?

@josefmay
Copy link

Still working on this at the moment.

@anveshthakur
Copy link
Contributor

Hi @kevinanielsen, Is this issue still being worked on? Can I take it up?

@kevinanielsen
Copy link
Owner

kevinanielsen commented Sep 9, 2024

Hi @kevinanielsen, Is this issue still being worked on? Can I take it up?

No update from @josefmay - @anveshthakur you can work on this :)

@josefmay josefmay removed their assignment Sep 9, 2024
@anveshthakur
Copy link
Contributor

Hi @kevinanielsen, I've raised a PR for this issue which can be found here #147

@kevinanielsen kevinanielsen linked a pull request Sep 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Improvements or additions to the api enhancement New feature or request go Language: Go
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants