Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version numbers #3296

Open
LornaSIL opened this issue Jan 22, 2025 · 5 comments
Open

Fix version numbers #3296

LornaSIL opened this issue Jan 22, 2025 · 5 comments

Comments

@LornaSIL
Copy link
Contributor

@mcdurdin we have these version numbers for some of the keyboards. Do I need to "fix" those?
1.01
0.51
1.21
1.05
2.0.25
1.26

Keyboards:

  • Udi(SIL)
  • ጉራጌ (Gurage) Legacy
  • Easy Chakma
  • Vietnamese Telex
  • Burushãski Girminas
  • Burushaski Girminas (بروشسکی)
@mcdurdin
Copy link
Member

Only 1.01 and 1.05 are potentially ambiguous. They should either be 1.1 or 1.0.1, and 1.5 or 1.0.5 respectively.

Each component of the version number is an integer, so 1.01 is major version 1 and minor version 1.

The components are called major, minor, patch. https://semver.org/ describes how we try and interpret the version numbers (although for keyboard purposes, the semantic meaning of the components is not very important -- just that version numbers go up).

@mcdurdin
Copy link
Member

mcdurdin commented Jan 24, 2025

Mind you, if we have an 0.5, 0.6, and 0.51, then 0.5 < 0.6 < 0.51 (aka 0.05 < 0.06 < 0.51)!

[sorry, mistyped the first time around, really doesn't help...]

@dyacob
Copy link
Contributor

dyacob commented Jan 25, 2025

I thought we fixed this for the Gurage keyboard a year ago or more -?? It must have been for another one. Unless someone is poised to make the Gurage Legacy version fix, I can do so this weekend.

@LornaSIL
Copy link
Contributor Author

LornaSIL commented Jan 25, 2025 via email

@LornaSIL
Copy link
Contributor Author

https://keyman.com/keyboards/rac_shina also needs version adjustment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants