Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: ErrorException: Notice: Undefined variable: build #533

Closed
sentry-io bot opened this issue Jan 24, 2025 · 0 comments · Fixed by #538
Closed

bug: ErrorException: Notice: Undefined variable: build #533

sentry-io bot opened this issue Jan 24, 2025 · 0 comments · Fixed by #538
Assignees
@mcdurdin
Labels
bug Something isn't working
Milestone
B18S1

Comments

@sentry-io
Copy link

sentry-io bot commented Jan 24, 2025

Sentry Issue: KEYMAN-COM-1DR

ErrorException: Notice: Undefined variable: build
  File "/index.php", line 94
    <tr><td>Endpoint:</td><td><input type='text' readonly size='60' value='<?= KeymanHosts::Instance()->s_keyman_com ?>/kmw/engine/<?=$build?>/keymanweb.js' onclick='this.select()'></td></tr>
@mcdurdin mcdurdin added this to the B18S1 milestone Jan 30, 2025
@mcdurdin mcdurdin self-assigned this Feb 2, 2025
@mcdurdin mcdurdin added the bug Something isn't working label Feb 2, 2025
@mcdurdin mcdurdin changed the title ErrorException: Notice: Undefined variable: build bug: ErrorException: Notice: Undefined variable: build Feb 2, 2025
@mcdurdin mcdurdin moved this to Todo in Keyman Feb 2, 2025
mcdurdin added a commit that referenced this issue Feb 5, 2025
@mcdurdin
fix: use KeymanWebHost::getKeymanWebUrlBase instead of $build global
42c5c48 
Fixes: #533
@mcdurdin mcdurdin mentioned this issue Feb 5, 2025
Merged
@mcdurdin mcdurdin moved this from Todo to In Progress in Keyman Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdurdin mcdurdin

Labels
bug Something isn't working
Projects
Keyman
Archived in project
Milestone
B18S1
Development

Successfully merging a pull request may close this issue.

fix: use KeymanWebHost::getKeymanWebUrlBase instead of $build global keymanapp/keyman.com
1 participant
@mcdurdin