Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(developer): verify version number and folder name in lexical models info build #13067

Closed
mcdurdin opened this issue Jan 29, 2025 · 0 comments · Fixed by #13118
Closed

feat(developer): verify version number and folder name in lexical models info build #13067

mcdurdin opened this issue Jan 29, 2025 · 0 comments · Fixed by #13118
Assignees
@mcdurdin
Labels
developer/ feat
Milestone
B18S1

Comments

@mcdurdin
Copy link
Member

  • Add a check in model-info build to ensure that we match the parent folder name precisely, e.g. burushos/burusho.bsk-latn.burushaski should not be a valid name.
  • Add a check in package or model-info build to verify that we don't have a blank version number.

From: keymanapp/lexical-models#297
@mcdurdin mcdurdin added this to the B18S1 milestone Jan 30, 2025
@mcdurdin mcdurdin self-assigned this Jan 30, 2025
@mcdurdin mcdurdin moved this to Todo in Keyman Jan 30, 2025
@mcdurdin mcdurdin mentioned this issue Feb 3, 2025
Merged
@mcdurdin mcdurdin moved this from Todo to In Progress in Keyman Feb 3, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Keyman Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdurdin mcdurdin

Labels
developer/ feat
Projects
Keyman
Archived in project
Milestone
B18S1
Development

Successfully merging a pull request may close this issue.

feat(developer): verify package version number format in kmc-package keymanapp/keyman
1 participant
@mcdurdin