Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifier Keys issue #1

Open
wpc009 opened this issue Sep 7, 2016 · 2 comments
Open

Modifier Keys issue #1

wpc009 opened this issue Sep 7, 2016 · 2 comments

Comments

@wpc009
Copy link

wpc009 commented Sep 7, 2016

I don't know if this is the right place for this issue.
Anyway.
It seems that Macro in current KLL spec treat the modifier key as the plain keys .

  1. If I pressed one modifier key, let's say RShift, then trigger a macro with a LShift in it's result.
  2. Do not release the RShift key.
  3. at the end of macro it will send a LShift release event to host, which cause the "shift" flag changed on host. But the 'RShift' is still pressed.

The ideal way should be before macro execute, check the current modifier key status, if it's result contains a modifier key and that key has already active, than ignore the modifier key in result. let's user to release that modifier key manually.
I think this way is better.

@haata
Copy link
Member

haata commented Sep 9, 2016

Hmm.

But what if you really wanted LShift not just "Shift"? And didn't care that RShift was being held.

This does make sense for the single quote macros though. Where you are trying to enter text. I'm thinking about changing how single quote macros work for KLL 0.6 anyways.

@wpc009
Copy link
Author

wpc009 commented Sep 15, 2016

In that case, it should recover the modifier flag at the end of the macro result.
I'm holding shift, but the keyboard behave like I'm not. This is confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants