Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"AuroraDialog" is missing #79

Open
MFlisar opened this issue Oct 9, 2024 · 2 comments
Open

"AuroraDialog" is missing #79

MFlisar opened this issue Oct 9, 2024 · 2 comments

Comments

@MFlisar
Copy link

MFlisar commented Oct 9, 2024

There is no dialog implementation inside aurora, am I correct? Any thoughts on this? Is there a way to implement modal dialogs in aurora? If not, do you plan to ad a dialog implementation?

Currently I only have a solution to misuse a AuroraWindow and disable the parent while it is shown, but this has a few problems like when enabling the parent after closing the dialog, the parent is not in the hierarchical position it was before anymore so other applications pop up in front of it. And the title bar can't be customised to show a close icon only.

@kirill-grouchnikov
Copy link
Owner

No plans right now, as I'm not familiar at all with the requirements or the implementation details of modal dialogs in Compose. Is there any pointer in the source code of core Compose (Material?) that can be used as the reference?

@MFlisar
Copy link
Author

MFlisar commented Oct 9, 2024

There is the androidx.compose.ui.window.DialogWindow composable that supports a desktop modal dialog.

Source code would be here: https://androidx.tech/artifacts/compose.ui/ui-desktop/1.7.0-source/desktopMain/androidx/compose/ui/window/Dialog.desktop.kt.html

Currently I still use this as it gives me the best overall result even though I can't style the dialog the same way as my application currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants