From a453c9514ab233d77611824fb4b8f5903876144f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Minh=20Nguy=E1=BB=85n?= <mxn@1ec5.org>
Date: Sat, 13 Jul 2024 22:29:31 -0700
Subject: [PATCH] Add common `*_name`-tags as global fields (#215)

Add `alt_name`, `loc_name`, `nat_name`, `official_name`, `reg_name`, `short_name` as global fields (which makes them `moreFields` for every preset) with the `prerequisiteTag` of `name` being present.
---
 data/fields/alt_name.json      | 16 ++++++++++++++++
 data/fields/loc_name.json      | 15 +++++++++++++++
 data/fields/nat_name.json      |  9 +++++++++
 data/fields/official_name.json | 14 ++++++++++++++
 data/fields/reg_name.json      |  9 +++++++++
 data/fields/short_name.json    | 14 ++++++++++++++
 interim/source_strings.yaml    | 28 ++++++++++++++++++++++++++++
 7 files changed, 105 insertions(+)
 create mode 100644 data/fields/alt_name.json
 create mode 100644 data/fields/loc_name.json
 create mode 100644 data/fields/nat_name.json
 create mode 100644 data/fields/official_name.json
 create mode 100644 data/fields/reg_name.json
 create mode 100644 data/fields/short_name.json

diff --git a/data/fields/alt_name.json b/data/fields/alt_name.json
new file mode 100644
index 000000000..78b77b24b
--- /dev/null
+++ b/data/fields/alt_name.json
@@ -0,0 +1,16 @@
+{
+    "key": "alt_name",
+    "type": "localized",
+    "label": "Alternative Name",
+    "universal": true,
+    "terms": [
+        "aka",
+        "alias",
+        "also known as",
+        "nonstandard name",
+        "secondary name"
+    ],
+    "prerequisiteTag": {
+        "key": "name"
+    }
+}
diff --git a/data/fields/loc_name.json b/data/fields/loc_name.json
new file mode 100644
index 000000000..1970af925
--- /dev/null
+++ b/data/fields/loc_name.json
@@ -0,0 +1,15 @@
+{
+    "key": "loc_name",
+    "type": "localized",
+    "label": "Local Name",
+    "universal": true,
+    "terms": [
+        "colloquial name",
+        "common name",
+        "informal name",
+        "nickname"
+    ],
+    "prerequisiteTag": {
+        "key": "name"
+    }
+}
diff --git a/data/fields/nat_name.json b/data/fields/nat_name.json
new file mode 100644
index 000000000..f0bbd0600
--- /dev/null
+++ b/data/fields/nat_name.json
@@ -0,0 +1,9 @@
+{
+    "key": "nat_name",
+    "type": "localized",
+    "label": "National Name",
+    "universal": true,
+    "prerequisiteTag": {
+        "key": "name"
+    }
+}
diff --git a/data/fields/official_name.json b/data/fields/official_name.json
new file mode 100644
index 000000000..023762551
--- /dev/null
+++ b/data/fields/official_name.json
@@ -0,0 +1,14 @@
+{
+    "key": "official_name",
+    "type": "localized",
+    "label": "Official Name",
+    "universal": true,
+    "terms": [
+        "formal name",
+        "full name",
+        "legal name"
+    ],
+    "prerequisiteTag": {
+        "key": "name"
+    }
+}
diff --git a/data/fields/reg_name.json b/data/fields/reg_name.json
new file mode 100644
index 000000000..0bb507667
--- /dev/null
+++ b/data/fields/reg_name.json
@@ -0,0 +1,9 @@
+{
+    "key": "reg_name",
+    "type": "localized",
+    "label": "Regional Name",
+    "universal": true,
+    "prerequisiteTag": {
+        "key": "name"
+    }
+}
diff --git a/data/fields/short_name.json b/data/fields/short_name.json
new file mode 100644
index 000000000..abea228ac
--- /dev/null
+++ b/data/fields/short_name.json
@@ -0,0 +1,14 @@
+{
+    "key": "short_name",
+    "type": "localized",
+    "label": "Short Name",
+    "universal": true,
+    "terms": [
+        "abbreviation",
+        "acronym",
+        "initialism"
+    ],
+    "prerequisiteTag": {
+        "key": "name"
+    }
+}
diff --git a/interim/source_strings.yaml b/interim/source_strings.yaml
index c14ca2c1a..41aad9cda 100644
--- a/interim/source_strings.yaml
+++ b/interim/source_strings.yaml
@@ -247,6 +247,11 @@ en:
         label: Air Conditioning
         # 'terms: cooling system,refrigeration'
         terms: '[translate with synonyms or related terms for ''Air Conditioning'', separated by commas]'
+      alt_name:
+        # alt_name=*
+        label: Alternative Name
+        # 'terms: aka,alias,also known as,nonstandard name,secondary name'
+        terms: '[translate with synonyms or related terms for ''Alternative Name'', separated by commas]'
       amenity:
         # amenity=*
         label: Type
@@ -3150,6 +3155,11 @@ en:
         label: Lit
         # 'terms: lamp,lighting'
         terms: '[translate with synonyms or related terms for ''Lit'', separated by commas]'
+      loc_name:
+        # loc_name=*
+        label: Local Name
+        # 'terms: colloquial name,common name,informal name,nickname'
+        terms: '[translate with synonyms or related terms for ''Local Name'', separated by commas]'
       location:
         # location=*
         label: Location
@@ -3499,6 +3509,10 @@ en:
         placeholder: Common name (if any)
         # 'terms: label,title'
         terms: '[translate with synonyms or related terms for ''Name'', separated by commas]'
+      nat_name:
+        # nat_name=*
+        label: National Name
+        terms: '[translate with synonyms or related terms for ''National Name'', separated by commas]'
       natural:
         # natural=*
         label: Natural
@@ -3680,6 +3694,11 @@ en:
           union: Labor Union Office
           # office=water_utility
           water_utility: Water Utility Office
+      official_name:
+        # official_name=*
+        label: Official Name
+        # 'terms: formal name,full name,legal name'
+        terms: '[translate with synonyms or related terms for ''Official Name'', separated by commas]'
       oneway:
         # oneway=*
         label: One Way
@@ -4410,6 +4429,10 @@ en:
         label: Taxiway Name
         # ref_taxiway field placeholder
         placeholder: e.g. A5
+      reg_name:
+        # reg_name=*
+        label: Regional Name
+        terms: '[translate with synonyms or related terms for ''Regional Name'', separated by commas]'
       relation:
         # type=*
         label: Type
@@ -4862,6 +4885,11 @@ en:
       shop:
         # shop=*
         label: Type
+      short_name:
+        # short_name=*
+        label: Short Name
+        # 'terms: abbreviation,acronym,initialism'
+        terms: '[translate with synonyms or related terms for ''Short Name'', separated by commas]'
       shower:
         # shower=*
         label: Showers