Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONFIG] Update YUNG's Better Desert Temples, Nether Fortresses and Strongholds configurations #11

Open
kkempfer opened this issue Jul 6, 2024 · 2 comments
Assignees
Labels
configuration Change the modpack configuration on hold This issue is temporarily paused

Comments

@kkempfer
Copy link
Owner

kkempfer commented Jul 6, 2024

What configuration should we change in this modpack?

YUNG's Better Desert Temples

The armorstands could display the wanderer armor from EnvironmentZ.
The itemframes storageItems could provide all kinds of Vanilla and modded seeds and food items.

YUNG's Better Strongholds

The armorstands could display the wolf pelt armor from EnvironmentZ.
The itemframes storageItems could provide all kinds of Vanilla and modded seeds and food items.

YUNG's Better Nether Fortresses

The itemframes lootItems could display cogs from Create.
The itemframes studyItems could display the guide book from Dehydration.
The ores chances should integrate zinc and salt from Create and Expanded Delight, respectively.
The rare block should integrate zinc block.

Why should it be changed?

To improve mod interoperability within the modpack.

Additional details

The configuration files do not account for modded items. The bug has been reported.

@kkempfer kkempfer added enhancement configuration Change the modpack configuration and removed enhancement labels Jul 6, 2024
@kkempfer kkempfer self-assigned this Oct 26, 2024
@kkempfer kkempfer added the on hold This issue is temporarily paused label Oct 26, 2024
@Scriese
Copy link

Scriese commented Jan 6, 2025

Hello Kkempfer,

thank you for looking into this issue. I tried delving into the code, suspecting that there was a simple solution to most of the problems listed here. I tracked the item choice process to the ItemRandomizer.class and ItemAdapter.class files in Yung's API, but those rely on content in net.minecraft, such as the core.Registry and world.item.Items files, which I couldn't read.

I have no coding knowledge, but based on what I could read and the fact that items in the configuration file have no namespaces - is it possible that the mods call upon the Forge registry entries (X_00000) format instead of the usual item IDs?

Forgive the layman's question and thank you!

@kkempfer
Copy link
Owner Author

kkempfer commented Jan 7, 2025

Hi @Scriese and thank you for looking into this issue too. I am using Fabric mod loader. Did you face the same problem with Forge ? Viiizee reported it in 2022, but the corresponding ticket is still open: YUNG-GANG/YUNGs-Better-Desert-Temples#13 I suggest you to comment it with your tests and explanations, in the hope that the YUNG-GANG devs will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration Change the modpack configuration on hold This issue is temporarily paused
Projects
None yet
Development

No branches or pull requests

2 participants