This repository has been archived by the owner on Jan 8, 2025. It is now read-only.
dev: update usage of apibara binaries [1] #1186
Labels
ci
Work that improves the continuous integration.
enhancement
Enhancement of the code, not introducing new features.
Comments
greged93
added
the
enhancement
anukkrit149
pushed a commit
to karnotxyz/kakarot-rpc
that referenced
this issue
Aug 9, 2024
<!--- Please provide a general summary of your changes in the title above --> <!-- Give an estimate of the time you spent on this PR in terms of work days. Did you spend 0.5 days on this PR or rather 2 days? --> Time spent on this PR: 1 day ## Pull request type <!-- Please try to limit your pull request to one type, submit multiple pull requests if needed. --> Please check the type of change your PR introduces: - [ ] Bugfix - [X] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Resolves kkrt-labs#1186 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> -New unit test for set_nonce -New unit test for set_implementation -New cairo func called test__set_nonce -New cairo func called test__set_implementation <!-- Reviewable:start --> - - - This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/1202) <!-- Reviewable:end -->
|
Fran: The only issue is that it always fetch the latest version. You can adapt the bash script to fetch a specific version https://install.apibara.com/install.sh Update: this issue is still fresh and should be tackled as part of our continuous improvement track |
|
Update: ❌ It needs to be enriched with a tech strategy to be assignable, Cc'ing @ClementWalter for next engineering strategy |
greged93
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the enhancement request
Currently to use the apibara binaries, we pull the image and then navigate the folders in order to pull the binary, which we then need to patch depending on the architecture used.
This can actually all be replaced by the following code:
https://gist.github.com/fracek/6a05a9986d3c3ba908bb086589733c4b
The issue will be deemed finished when:
Duration: 1 hour
The text was updated successfully, but these errors were encountered: