Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play bell as media, not notification #31

Closed
lkblkb opened this issue Jun 11, 2021 · 7 comments
Closed

Play bell as media, not notification #31

lkblkb opened this issue Jun 11, 2021 · 7 comments
Labels
accepted Planning to implement enhancement New feature or request

Comments

@lkblkb
Copy link

lkblkb commented Jun 11, 2021

Super app!

My phone lives in vibrate mode because I have a lot of notifications and it would be super annoying to have these ringing constantly.

However this also means the app does not work for me, since the bells are notifications and not media.

This may be an unusual case but it would be awesome to have the option to play the bell as media :)

@kmac
Copy link
Owner

kmac commented Jun 11, 2021

Thanks for the feedback - much appreciated! Yes, I've been meaning to provide this as an option.
I'll try to do something for it when I add the separate in-app volume control. It may be a few weeks however - I'm quite busy with a new job at the moment.

@kmac kmac added accepted Planning to implement enhancement New feature or request labels Jun 11, 2021
@lkblkb
Copy link
Author

lkblkb commented Jun 12, 2021

Awesome, thank you! No hurry.

@march42
Copy link

march42 commented Jun 12, 2021

This would be a great feature, thanks for suggesting it. Thanks for this App and your efforts on this topic.

@kmac
Copy link
Owner

kmac commented Jun 14, 2021

Added in 1.0.16. The preference is in the 'Sound' menu, along with the bell configurations (I renamed the 'Bell' menu to 'Sound' with this update). You can select between three channels: notification, media, and alarm.

@kmac kmac closed this as completed Jun 14, 2021
@lkblkb
Copy link
Author

lkblkb commented Jun 27, 2021

Thanks you! I updated but the audio does not play via media it seems. Audio channel is set to media. But I need to turn off the phone's vibrate or silent mode to get the bell to play. Media audio for other apps works fine while the phone is on vibrate.

@kmac
Copy link
Owner

kmac commented Jul 1, 2021

I think you're probably looking for Issue #22 - which I'm having some difficulty figuring out how to implement. I'm using an audio library that mutes the sound as per the android system, which is why no audio is playing when you have you're phone muted.

Further complicating things is that Android is changing all of this behaviour as the versions update. Which version of Android are you running?

Can I suggest trying the 'alarm' channel? Alarms are often treated as a higher priority. Again, it depends on your Android version.

The other thing you could try for the media channel is to manually set the volume on your notification channel to 0 (rather than mute your phone), and set the media volume to whatever you like. There shouldn't be anything coming through the media channel other than if you are playing media.

Hope this helps.

kmac added a commit that referenced this issue Aug 1, 2021
Phone mute/vibrate setting only applies to notification channel

Previously the global phone mute/vibrate notification setting
was applied to notification sound regardless of the selected
notification channel. This kind of defeats the purpose of having
separate notification channels.

This commit changes the behaviour to only consider the phone
mute/vibrate setting if the 'notification' channel is used.
If the sound channel is set to 'media' or 'alarm' the mindful
bell notifications will sound regardless of the phone mute/vibrate
setting. In this case you can still mute the bell via the
app 'Mute' toggle switch on the main app screen.

Summary:
- App mute is enabled: always mute
- For notification channel: honour the phone silent/vibrate-only setting
- For media and alarm channels, allow sound unless DND is enabled
@lkblkb
Copy link
Author

lkblkb commented Aug 31, 2021

@kmac just want to say thank you for this, it's working now and I really appreciate this project! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Planning to implement enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants