Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Specify base image using ko:// URL #955

Closed
imjasonh opened this issue Feb 8, 2023 · 1 comment
Closed

Idea: Specify base image using ko:// URL #955

imjasonh opened this issue Feb 8, 2023 · 1 comment

Comments

@imjasonh
Copy link
Member

imjasonh commented Feb 8, 2023

tl;dr:

baseImageOverrides:
  github.com/my-user/my-repo/cmd/a: ko://github.com/my-user/my-repo/cmd/b

When building ./cmd/a, this would first build and publish ./cmd/b, and use that image as the base for ./cmd/a.

We'd need to detect and prevent cycles in this case, e.g.:

defaultBaseImage: ko://github.com/my-user/my-repo/cmd/b

(where baseImageOverrides doesn't specify a different base for ./cmd/b)

or:

baseImageOverrides:
  github.com/my-user/my-repo/cmd/a: ko://github.com/my-user/my-repo/cmd/b
  github.com/my-user/my-repo/cmd/b: ko://github.com/my-user/my-repo/cmd/a

This is a potential solution to #251

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant