Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move is copy when SBO is in effect #1

Open
ReimuNotMoe opened this issue May 3, 2024 · 0 comments
Open

Move is copy when SBO is in effect #1

ReimuNotMoe opened this issue May 3, 2024 · 0 comments

Comments

@ReimuNotMoe
Copy link

When not using SMALL_MEMCPY_STRATEGY and SBO is in effect, moving a Cyto::Any actually creates a copy.

See this line:

Any/cyto-any.h

Line 294 in 0292fa3

AnyTraits::make(dst, std::in_place_type_t<X>(), std::move(*static_cast<X const *>(static_cast<void const *>(&src->buf))));

The const qualifiers should be removed for std::move to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant