-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash during parsing of malformed GIF #179
Comments
I don't know that this is actually a problem; anyway I'd like to see more explanation. What's happening is that the When I run this gif with sanitizers, no access problems are reported. There was an UB related to integer overflow, but I've fixed that in a commit (and I doubt it was exploitable). |
Hmm integer overflow somewhere along the way makes sense. Regardless, thanks for the fix! |
To be clear, I believe you will still get a report like the above. |
I see. Perhaps a check or warning for a less-than-sane pixel size? |
Hi folks,
An interesting crash was found while fuzz testing of the gifsicle binary which can be triggered via a malformed GIF file. Although this malformed file only crashes the program as-is, it could potentially be crafted further and create a security issue where these kinds of files would be able compromise the process's memory through taking advantage of affordances given by memory corruption. It's recommend to harden the code to prevent these kinds of bugs as it could greatly mitigate such this issue and even future bugs.
crash.gif (base64 encoded due to file format)
debug log
(requires the electric fence malloc debugger library to instrument the memory manager to find the subtle crash: sudo apt-get install electric-fence)
Thanks!
The text was updated successfully, but these errors were encountered: