Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5th review commnt #4

Open
unicornx opened this issue Dec 18, 2024 · 1 comment
Open

5th review commnt #4

unicornx opened this issue Dec 18, 2024 · 1 comment

Comments

@unicornx
Copy link

unicornx commented Dec 18, 2024

comment 1

参考 #3 (comment) 对 DPT_BOARD_TYPE/DPT_PATH_KERNEL/DPT_PATH_OUTPUT 其实可以直接用环境变量,不需要用命令参数方式解析的,会简单一些。就是写在 mkpkg 前面,然后脚本中就可以得到。

comment 2

我觉得可以继续简化目前的实现,直接实现一个脚本叫 mkpkg.sh 就好了,就是直接代替 tool.sh ,以后直接执行 ./mkpkg.sh 就好了

comment 3

bash 有个 getopts 的函数可以用来处理 -a / -l 这种参数。你可以试试

comment 4

我测试了 duo256M, 大核可以,但是小核打印出不来,你那边测试过吗?

@jiuyueshenhua
Copy link

小核打印不出来,对应的prebuild应该没更新。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants