From 72bfb28afc903edcc4b1c18a820fcad1d3491807 Mon Sep 17 00:00:00 2001 From: Kerry McKeever Date: Mon, 19 Dec 2022 17:13:34 -0500 Subject: [PATCH] Fix selectAllLocaleText bug and pagination flakiness (#36) * 1.1.0 * 1.1.1 * Add fixes for selectAllLocaleText and flakiness in pagination * 2.0.2 --- package-lock.json | 2 +- package.json | 2 +- src/agGrid/agGridInteractions.js | 3 ++- src/agGrid/agGridValidations.js | 1 + 4 files changed, 5 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 19c981d..2ec3414 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "cypress-ag-grid", - "version": "2.0.0", + "version": "2.0.2", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 143eeda..590fa7c 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "cypress-ag-grid", - "version": "2.0.1", + "version": "2.0.2", "description": "Cypress plugin to interact with ag grid", "main": "src/index.js", "repository": { diff --git a/src/agGrid/agGridInteractions.js b/src/agGrid/agGridInteractions.js index c745032..1816aee 100644 --- a/src/agGrid/agGridInteractions.js +++ b/src/agGrid/agGridInteractions.js @@ -458,7 +458,8 @@ export function filterByCheckboxColumnMenu(agGridElement, options) { const _options = populateSearchCriteria( _searchCriteria, options.hasApplyButton, - options.noMenuTabs + options.noMenuTabs, + options.selectAllLocaleText ); _filterByCheckboxColumnMenu(agGridElement, _options); }); diff --git a/src/agGrid/agGridValidations.js b/src/agGrid/agGridValidations.js index cf95536..bf72f66 100644 --- a/src/agGrid/agGridValidations.js +++ b/src/agGrid/agGridValidations.js @@ -25,6 +25,7 @@ export function validateTableRowSubset(agGridElement, actualTableData,expectedTa export function validateTablePages(agGridElement,expectedPaginatedTableData, onlyColumns = {}) { let iterator = 0; expectedPaginatedTableData.forEach((expectedPage) => { + cy.get('.ag-cell').should('be.visible'); cy.get(agGridElement) .getAgGridData(onlyColumns) .then((table) => {