Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync api typehints are async typehints #548

Closed
ion-elgreco opened this issue Jan 13, 2025 · 1 comment
Closed

Sync api typehints are async typehints #548

ion-elgreco opened this issue Jan 13, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@ion-elgreco
Copy link

Which project are you reporting a bug for?

kr8s

What happened?

All apis that are non-async, actually have the async api typehint.

Pod.get typehint shows up as this:

(method) def get(
    name: str | None = None,
    namespace: str | None = None,
    api: Api | None = None,
    label_selector: str | dict[str, str] | None = None,
    field_selector: str | dict[str, str] | None = None,
    timeout: int = 2,
    **kwargs: Unknown
) -> Coroutine[Any, Any, Pod]

Anything else?

No response

@ion-elgreco ion-elgreco added the bug Something isn't working label Jan 13, 2025
@jacobtomlinson
Copy link
Member

This is a known issue. There is a discussion of potential solutions in #491. Closing as a duplicate of #491.

@jacobtomlinson jacobtomlinson closed this as not planned Won't fix, can't repro, duplicate, stale Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants