Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fatal] (createNode) Unimplemented: node operation SplitToSequence #50

Open
Khubaib96 opened this issue May 30, 2024 · 2 comments
Open
Labels
operand missing ONNX operand not yet implemented in onnx2c

Comments

@Khubaib96
Copy link

This is my onnx model.
denoiser.onnx

when i run the command:

./onnx2c ./denoiser_model.onnx > model.c

I get these error:

onnx2c: /mnt/d/onnx2c/src/graph.cc:549: toC::Node* toC::Graph::createNode(std::string): Assertion false' failed.
Aborted`

How to resolve this?

@kraiskil
Copy link
Owner

Hi Khubaib96

How to resolve this?

These two links should get you going:
https://github.com/kraiskil/onnx2c/blob/master/development.md#adding-a-new-nodeop-implementation
https://github.com/onnx/onnx/blob/main/docs/Operators.md#SplitToSequence

But quickly skimming through the SplitToSequence operator documentation, it does feel like its output tensor's dimension could maybe be data dependent (i.e. determinable only at run-time)? If so, implementing that would require dynamic memory allocation, which onnx2c does not allow.

@Khubaib96
Copy link
Author

Hi, thank you for your quick response.

This model takes 480 input samples and returns 480 output samples. If we provide fewer than 480 input samples, it automatically adds zeros to make it 480 (as a part of preprocessing) not a part of model itself. I'll check my model to see if we can make it work statically.

@kraiskil kraiskil added the operand missing ONNX operand not yet implemented in onnx2c label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
operand missing ONNX operand not yet implemented in onnx2c
Projects
None yet
Development

No branches or pull requests

2 participants