Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric_profile Field in CreateExperiment for Local Monitoring #1443

Open
shreyabiradar07 opened this issue Dec 26, 2024 · 0 comments
Open
Labels

Comments

@shreyabiradar07
Copy link
Contributor

Describe the feature

Currently CreateExperiment JSON uses performance_profile field referencing metric profile in local monitoring as previously Kruize was using a common experiment database table. Now with concurrent RM and LM feature released with 0.3 we have separate database tables for experiments in remote and local monitoring and hence metric_profile field can be added replacing performance_profile for local monitoring usecase.

Examples or references

Reference - CreateExperiment in local monitoring

Below is example createExperiment JSON payload replacing performance_profile with metadata_profile

[
  {
    "version": "v2.0",
    "experiment_name": "default|default|deployment|tfb-qrh-deployment",
    "cluster_name": "default",
    
    # performance_profile -> metric_profile
    "metric_profile": "resource-optimization-local-monitoring",
    
    "mode": "monitor",
    "target_cluster": "local",
    "kubernetes_objects": [
      {
        "type": "deployment",
        "name": "tfb-qrh-deployment",
        "namespace": "default",
        "containers": [
          {
            "container_image_name": "kruize/tfb-db:1.15",
            "container_name": "tfb-server-0"
          },
          {
            "container_image_name": "kruize/tfb-qrh:1.13.2.F_et17",
            "container_name": "tfb-server-1"
          }
        ]
      }
    ],
    "trial_settings": {
      "measurement_duration": "15min"
    },
    "recommendation_settings": {
      "threshold": "0.1"
    },
    "datasource": "prometheus-1"
  }
]

Suggest a solution

Add metric_profile field in KruizeLMExperimentEntry table

Additional Context

Any additional context about the feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

1 participant