Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try out other prometheus client libraries #55

Closed
2 tasks done
clux opened this issue Aug 6, 2023 · 1 comment · Fixed by #72
Closed
2 tasks done

try out other prometheus client libraries #55

clux opened this issue Aug 6, 2023 · 1 comment · Fixed by #72
Assignees

Comments

@clux
Copy link
Member

clux commented Aug 6, 2023

The tikv one barely gets updates, has shown no activity on any of my previous issues / prs, so I am skeptical it will ever support exmplars/openmetrics or newer features.

@clux clux added the help wanted Extra attention is needed label Aug 6, 2023
@clux clux linked a pull request Jun 21, 2024 that will close this issue
@clux clux removed the help wanted Extra attention is needed label Jun 21, 2024
@clux clux self-assigned this Jun 21, 2024
@clux clux changed the title try out the official prometheus_client library try out other prometheus client libraries Jun 21, 2024
@clux clux linked a pull request Jun 22, 2024 that will close this issue
@clux
Copy link
Member Author

clux commented Jun 22, 2024

Have done a bit of testing of two competing metrics crates (the ones i would use personally):

The end result is not massively different in terms of code (despite measured's performance focus), local rebuild times (touch metrics.rs && cargo build with and without release) are both identical on my machine, and still both marginally faster than the current tikv crate, which was kind of surprising with their proc macro usage.

Unclear which one to go with as of yet, or if I have missed something important. The official one is lacking in terms of maintenance and sophistication, and measured is slightly complex and lacks exemplars. If the official one had more maintenance I might like that more, but currently leaning towards helping measured getting some better ergonomics in the edge places.

@clux clux closed this as completed in #72 Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant