Trying to understand how gzip works in kube-rs

[goenning]

I found the gzip feature and when searching the code it seems like it only adds the decompression layer. But who/where is the accept-encoding request header set?

my understanding is that api server will only compress if both the request header is set and the feature gate is enabled.

[clux]

As far as I've understood it, the DecompressionLayer is in charge of setting the Accept-Encoding header to requests.

[clux]

Dug a bit deeper because I started doubting it (all of their doc test insert the header manually).

We construct a DecompressionLayer::new() in client/builder.rs (with the gzip = ["client", "tower-http/decompression-gzip"] feature).

This new method defers to AcceptEncoding::default, which allows all of the compression algorithms. This is later filtered down to just gzip based on compiled-in features.

The decompression layer then ensures the ACCEPT_ENCODING header has an entry, so it should do what it says on the tin.

[goenning]

Ah right, that makes sense, I haven't looked at that crate, I was just looking inside kube-rs thinking that I'd have to set it myself. Thanks for digging that out!