Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Improved table layout (#677) #680

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Improved table layout (#677) #680

wants to merge 1 commit into from

Conversation

harshita9104
Copy link

Which issue(s) this PR fixes:

Fixes #677

What kind of change does this PR introduce?

  • Bug fix: Table layout issues on the Partners page

What is the current behavior? (You can also link to an open issue here)

  • The table layout is cut off, with unused space on the left and right.
  • The Product column is too wide, while the Description column is too narrow, making text congested.
  • Full URLs are displayed instead of clickable hyperlinks (e.g., “Visit Website”).

What is the new behavior (if this is a feature change)?

  • Table now utilizes the full width properly, improving readability.
  • Product column width is reduced, and Description column is expanded for better text flow.
  • Website links are now clickable ("Visit Website"), improving UI clarity.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • No breaking changes; this PR only improves UI layout & readability.

Screenshots (if applicable)

Before

image

✅After

image

Additional Notes

  • Please review and let me know if further adjustments are required.
  • This PR ensures that the Partners page looks professional and provides a better user experience.

🚀 Looking forward to your feedback!

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign shelley-baoyue after the PR has been reviewed.
You can assign the PR to them by writing /assign @shelley-baoyue in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 10, 2025
@harshita9104 harshita9104 force-pushed the fix-partners-table-final branch from 812ee96 to e56f83b Compare February 10, 2025 10:21
@harshita9104
Copy link
Author

/assign @Shelley-BaoYue

Hello @dingyin , @edisonxiang ,
Kindly review the PR !
I have solved the issue (#677) successfully!!

Thank you

@harshita9104
Copy link
Author

Hello @Shelley-BaoYue ,

This PR will complete one of the task of the issue #665 ,
Design and optimization of the partner page, including design and code updates.

Thank you!

@harshita9104 harshita9104 mentioned this pull request Feb 11, 2025
Open
5 tasks
Shelley-BaoYue
Shelley-BaoYue reviewed Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions! Now the page does look more beautiful and clean! But we hope to redesign the page in the future, such as shown in the form of a card.
/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2025
@harshita9104
Copy link
Author

harshita9104 commented Feb 11, 2025 •
edited
Loading

Kindly review the PR !!
@dingyin , @edisonxiang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shelley-BaoYue Shelley-BaoYue Shelley-BaoYue left review comments

@dingyin dingyin Awaiting requested review from dingyin

@edisonxiang edisonxiang Awaiting requested review from edisonxiang

Assignees

@Shelley-BaoYue Shelley-BaoYue

Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table Layout Issues on Partners Page - Content Cut Off & Uneven Formatting
3 participants
@harshita9104 @kubeedge-bot @Shelley-BaoYue