From 09e1ac17011c3a384d4123381ac3bb0128402dbf Mon Sep 17 00:00:00 2001 From: Mingjie Tang Date: Tue, 18 Jun 2019 18:28:32 -0700 Subject: [PATCH] update the job status api (#44) --- job_controller/api/v1/interface.go | 2 +- job_controller/job.go | 2 +- job_controller/test_job_controller.go | 2 +- test_job/v1/test_job_controller.go | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/job_controller/api/v1/interface.go b/job_controller/api/v1/interface.go index c0ce8be0..946d2109 100644 --- a/job_controller/api/v1/interface.go +++ b/job_controller/api/v1/interface.go @@ -38,7 +38,7 @@ type ControllerInterface interface { DeleteJob(job interface{}) error // UpdateJobStatus updates the job status and job conditions - UpdateJobStatus(job interface{}, replicas map[ReplicaType]*ReplicaSpec, jobStatus JobStatus) error + UpdateJobStatus(job interface{}, replicas map[ReplicaType]*ReplicaSpec, jobStatus *JobStatus) error // UpdateJobStatusInApiServer updates the job status in API server UpdateJobStatusInApiServer(job interface{}, jobStatus *JobStatus) error diff --git a/job_controller/job.go b/job_controller/job.go index 817d2c34..1c90b4e5 100644 --- a/job_controller/job.go +++ b/job_controller/job.go @@ -210,7 +210,7 @@ func (jc *JobController) ReconcileJobs( } } - err = jc.Controller.UpdateJobStatus(job, replicas, jobStatus) + err = jc.Controller.UpdateJobStatus(job, replicas, &jobStatus) if err != nil { log.Warnf("UpdateJobStatus error %v", err) return err diff --git a/job_controller/test_job_controller.go b/job_controller/test_job_controller.go index f0f00655..d969fa23 100644 --- a/job_controller/test_job_controller.go +++ b/job_controller/test_job_controller.go @@ -68,7 +68,7 @@ func (t *TestJobController) DeleteJob(job interface{}) error { } func (t TestJobController) UpdateJobStatus(job interface{}, replicas map[apiv1.ReplicaType]*apiv1.ReplicaSpec, - jobStatus apiv1.JobStatus) error { + jobStatus *apiv1.JobStatus) error { return nil } diff --git a/test_job/v1/test_job_controller.go b/test_job/v1/test_job_controller.go index e19b0c21..77014346 100644 --- a/test_job/v1/test_job_controller.go +++ b/test_job/v1/test_job_controller.go @@ -68,7 +68,7 @@ func (t *TestJobController) DeleteJob(job interface{}) error { } func (t *TestJobController) UpdateJobStatus(job interface{}, replicas map[apiv1.ReplicaType]*apiv1.ReplicaSpec, - jobStatus apiv1.JobStatus) error { + jobStatus *apiv1.JobStatus) error { return nil }