Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

central-dashboard: Configure build_version dynamically through ENV var #16

Open
orfeas-k opened this issue Sep 19, 2023 · 2 comments
Open

Comments

@orfeas-k
Copy link

orfeas-k commented Sep 19, 2023

/kind feature

Context
At the moment, KF's build version in the dashboard is defined only during build time. More specifically and as explained thoroughly in this issue #25, it is not even defined and thus it is constantly dev_local.

For some more thorough technical context, in theory, it can also be defined during runtime through a custom resource that doesn't exist anymore in KF (here with the callback trace being 1, 2 and 3).

Feature
Configure the build_version dynamically during runtime by using a deployment's ENV variable.

Why you need this feature:
This will allow for anyone to be able to configure the build_version value in their distribution without having to rebuild the image.

Describe the solution you'd like:
The solution can be inspired at a great extent what has been done for centraldashboard-angular component in kubeflow/kubeflow#6918. The changes that really interest us are the ones in backend k8s_service.ts file. We could also consider splitting build_version to buildVersion, buildId and buildLabel but that's optional. Then, we may have to implement the new ENV variables here, although if we use kubeflowVersion, changing only where k8s gets this variable from may be enough.

@andreyvelich
Copy link
Member

/transfer dashboard

Copy link

@orfeas-k: The label(s) kind/feature cannot be applied, because the repository doesn't have them.

In response to this:

/kind feature

Context
At the moment, KF's build version in the dashboard is defined only during build time. More specifically and as explained thoroughly in this issue #25, it is not even defined and thus it is constantly dev_local.

For some more thorough technical context, in theory, it can also be defined during runtime through a custom resource that doesn't exist anymore in KF (here with the callback trace being 1, 2 and 3).

Feature
Configure the build_version dynamically during runtime by using a deployment's ENV variable.

Why you need this feature:
This will allow for anyone to be able to configure the build_version value in their distribution without having to rebuild the image.

Describe the solution you'd like:
The solution can be inspired at a great extent what has been done for centraldashboard-angular component in kubeflow/kubeflow#6918. The changes that really interest us are the ones in backend k8s_service.ts file. We could also consider splitting build_version to buildVersion, buildId and buildLabel but that's optional. Then, we may have to implement the new ENV variables here, although if we use kubeflowVersion, changing only where k8s gets this variable from may be enough.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot transferred this issue from kubeflow/kubeflow Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Do
Development

No branches or pull requests

2 participants