Add annotation to namespace from profile CRD

[mareksimunek]

/kind question

Question:
Hi, I want to add annotation to a namespace created by kubeflow Profiles. If I looked correctly its not possible, only annotations added to a namespace is the owner of the profile.

https://github.com/kubeflow/kubeflow/blob/b922fa1573e4f0d19548f5ea94dbe3f78826bfed/components/profile-controller/controllers/profile_controller.go#L129

So with:

apiVersion: kubeflow.org/v1beta1
kind: Profile
metadata:
  name: test
spec:
  owner:
    kind: User
    name: [email protected]

Namespace created is:

>kubectl describe namespace test
Name:         test
Labels:       app.kubernetes.io/part-of=kubeflow-profile
              istio-injection=enabled
              katib.kubeflow.org/metrics-collector-injection=enabled
              kubernetes.io/metadata.name=test
              pipelines.kubeflow.org/enabled=true
              serving.kubeflow.org/inferenceservice=enabled
Annotations:  owner: [email protected]

Motivation:

We want to have several nodes in cluster dedicated to production workload and with annotation on namespace

> kubectl describe namespace production
Name:         production
Annotations: 
              scheduler.alpha.kubernetes.io/node-selector: workset=production

we are able to separete production and research experimentation workloads.

Am I missing something or its a thing for contribution?

[andreyvelich]

/transfer dashboard

[google-oss-prow]

@mareksimunek: The label(s) kind/question cannot be applied, because the repository doesn't have them.

In response to this:

/kind question

Question:
Hi, I want to add annotation to a namespace created by kubeflow Profiles. If I looked correctly its not possible, only annotations added to a namespace is the owner of the profile.

https://github.com/kubeflow/kubeflow/blob/b922fa1573e4f0d19548f5ea94dbe3f78826bfed/components/profile-controller/controllers/profile_controller.go#L129

So with:

apiVersion: kubeflow.org/v1beta1
kind: Profile
metadata:
 name: test
spec:
 owner:
   kind: User
   name: [email protected]

Namespace created is:

>kubectl describe namespace test
Name:         test
Labels:       app.kubernetes.io/part-of=kubeflow-profile
             istio-injection=enabled
             katib.kubeflow.org/metrics-collector-injection=enabled
             kubernetes.io/metadata.name=test
             pipelines.kubeflow.org/enabled=true
             serving.kubeflow.org/inferenceservice=enabled
Annotations:  owner: [email protected]

Motivation:

We want to have several nodes in cluster dedicated to production workload and with annotation on namespace

> kubectl describe namespace production
Name:         production
Annotations: 
             scheduler.alpha.kubernetes.io/node-selector: workset=production

we are able to separete production and research experimentation workloads.

Am I missing something or its a thing for contribution?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.