Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(backend): remove usage of deprecated commonLabels in Kustomize manifests #11289

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore(backend): remove usage of deprecated commonLabels in Kustomize manifests #11289

wants to merge 2 commits into from

Conversation

etheleon
Copy link

@etheleon etheleon commented Oct 12, 2024 •
edited
Loading

Description of your changes:

Removed commonLabels since it's deprecated in Kustomize's api/v0.16.0 release. In it's place labels and selectors should be mentioned explicitly in the resource.

Checklist:

@google-oss-prow Google OSS Prow
Copy link

Hi @etheleon. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@etheleon
Copy link
Author

resolves #11272

@etheleon etheleon marked this pull request as draft October 12, 2024 12:59
@etheleon etheleon mentioned this pull request Oct 12, 2024
Open
@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Oct 16, 2024
@etheleon etheleon force-pushed the update-manifests-issue-11272 branch 7 times, most recently from 2ac97d1 to 2b40df0 Compare October 16, 2024 05:14
@etheleon
Copy link
Author

running grep -r "commonLabels" does not return any file

@etheleon etheleon marked this pull request as ready for review October 16, 2024 05:17
@etheleon
Copy link
Author

/verify-owners

@hbelmiro
Copy link
Contributor

/ok-to-test
/rerun-all

@HumairAK HumairAK added this to the KFP 2.4.0 milestone Oct 16, 2024
@DharmitD
Copy link
Contributor

@HumairAK could you approve the workflow runs? ty!

@github-actions github-actions bot added the ci-passed All CI tests on a pull request have passed label Oct 16, 2024
@hbelmiro
Copy link
Contributor

/ok-to-test
/rerun-all

@hbelmiro
Copy link
Contributor

hbelmiro commented Nov 1, 2024

@etheleon did you had the chance to see my comments here?
#11289 (review)

@etheleon etheleon requested a review from hbelmiro November 3, 2024 01:45
hbelmiro
hbelmiro reviewed Nov 4, 2024
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @etheleon.
You still need to sign off your commits.

@etheleon
Copy link
Author

etheleon commented Nov 5, 2024

Thank you @etheleon. You still need to sign off your commits.

Let me rebase and sign off thanks for reminding

@etheleon etheleon force-pushed the update-manifests-issue-11272 branch from 2c5cee5 to c53d0fc Compare November 6, 2024 06:07
@etheleon etheleon requested a review from hbelmiro November 6, 2024 06:10
hbelmiro
hbelmiro reviewed Nov 6, 2024
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cc @HumairAK

@google-oss-prow google-oss-prow bot added the lgtm label Nov 6, 2024
@hbelmiro
Copy link
Contributor

@HumairAK @chensun
Can we merge this if it makes sense to you? Otherwise, could you please share your feedback so the author can work on it on time for KFP 2.4?

@github-actions github-actions bot added the ci-passed All CI tests on a pull request have passed label Nov 27, 2024
@HumairAK
Copy link
Collaborator

HumairAK commented Jan 9, 2025

@etheleon would like to get this into 2.4, do you think you can rebase?

@HumairAK HumairAK mentioned this pull request Jan 10, 2025
Merged
HumairAK
HumairAK requested changes Jan 13, 2025
View reviewed changes
manifests/kustomize/base/postgresql/cache/cache-deployment-patch.yaml Outdated
@@ -2,7 +2,12 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: cache-server
label:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
label:
labels:

manifests/kustomize/base/postgresql/pipeline/ml-pipeline-apiserver-deployment-patch.yaml Outdated Show resolved Hide resolved
manifests/kustomize/base/postgresql/pipeline/ml-pipeline-apiserver-deployment-patch.yaml Outdated Show resolved Hide resolved
manifests/kustomize/base/cache-deployer/cache-deployer-deployment.yaml Outdated Show resolved Hide resolved
@HumairAK
Copy link
Collaborator

There are some requested changes, let's move this to kfp 2.5 while we address them.

@HumairAK HumairAK modified the milestones: KFP 2.4.0, KFP 2.5.0 Jan 13, 2025
@google-oss-prow Google OSS Prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow bot removed the lgtm label Jan 15, 2025
@etheleon etheleon force-pushed the update-manifests-issue-11272 branch 3 times, most recently from cc8d65c to 394d31b Compare January 15, 2025 08:50
@etheleon
🔧 Replace commonLabels with labels and selectors
2478115 
Used `kustomize edit fix  --vars`

Signed-off-by: etheleon <[email protected]>
@etheleon
fix comments
e78db20 
Signed-off-by: etheleon <[email protected]>
@etheleon etheleon force-pushed the update-manifests-issue-11272 branch from 394d31b to e78db20 Compare January 15, 2025 09:05
@etheleon etheleon requested review from HumairAK and hbelmiro January 15, 2025 09:15
@hbelmiro
Copy link
Contributor

/ok-to-test

@github-actions GitHub Actions
Copy link

Approvals successfully granted for pending runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkcalat gkcalat Awaiting requested review from gkcalat

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

@DharmitD DharmitD Awaiting requested review from DharmitD

@HumairAK HumairAK Awaiting requested review from HumairAK

@hbelmiro hbelmiro Awaiting requested review from hbelmiro

Assignees

@hbelmiro hbelmiro

Labels
ci-passed All CI tests on a pull request have passed ok-to-test size/L
Projects
None yet
Milestone
KFP 2.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@etheleon @hbelmiro @DharmitD @HumairAK