From 4ca3b7663aedcd76016a4c8e273368bd75af217c Mon Sep 17 00:00:00 2001 From: Chris Privitere <23177737+cprivitere@users.noreply.github.com> Date: Fri, 24 May 2024 17:09:42 -0500 Subject: [PATCH] test: clean up wanterr logic to be more readable as an assert Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com> --- internal/emlb/emlb_test.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/internal/emlb/emlb_test.go b/internal/emlb/emlb_test.go index 251fe127..9f1ec5b8 100644 --- a/internal/emlb/emlb_test.go +++ b/internal/emlb/emlb_test.go @@ -167,11 +167,12 @@ func Test_getExternalIPv4Target(t *testing.T) { t.Run(tt.name, func(t *testing.T) { g := NewWithT(t) got, err := getExternalIPv4Target(tt.args.deviceAddr) - if (err != nil) != tt.wantErr { - g.Expect(err).To(Equal(tt.wantErr)) - return + if tt.wantErr { + g.Expect(err).To(HaveOccurred()) + } else { + g.Expect(err).ToNot(HaveOccurred()) + g.Expect(got).To(Equal(tt.want)) } - g.Expect(got).To(Equal(tt.want)) }) } }