From 012befe5088cd1b0f42b6435243b507d1c28f828 Mon Sep 17 00:00:00 2001 From: Daniel Hiller Date: Thu, 28 Nov 2024 17:03:27 +0100 Subject: [PATCH] sigs,generate: improve validation, update sig-list generation (#350) * sigs,validator: update validator code Update validator code to take into account new sigs.yaml fields. Add validation for chairs, leads, labels and directories. Signed-off-by: Daniel Hiller * update sig-list md template - missing values Signed-off-by: Daniel Hiller * generate: add sig validator call Signed-off-by: Daniel Hiller * sigs.yaml: remove non existing dirs and OWNERS Signed-off-by: Daniel Hiller * sigs.yaml,wg-arch,wg-code-quality: correct labels Update labels to future correct ones. Signed-off-by: Daniel Hiller * sigs.yaml,chairs: add kubevirt community chair Add aburdenthehand as community chair. Note: this is only stating the obvious Signed-off-by: Daniel Hiller * sigs.yaml,sig-list: run make generate Updates yaml formatting and regenerates the sig-list markdown. Signed-off-by: Daniel Hiller --------- Signed-off-by: Daniel Hiller --- Makefile | 1 + generators/cmd/sigs/sig-list.gomd | 2 +- pkg/labels/file.go | 40 +++ pkg/labels/types.go | 43 +++ pkg/orgs/file.go | 40 +++ pkg/orgs/types.go | 46 +++ pkg/orgs/types_test.go | 164 +++++++++ pkg/sigs/{sigs.go => file.go} | 0 pkg/sigs/types.go | 21 +- sig-list.md | 26 +- sigs.yaml | 456 +++++++++++++------------- validators/cmd/sigs/sigs-validator.go | 181 ++++++++-- 12 files changed, 735 insertions(+), 285 deletions(-) create mode 100644 pkg/labels/file.go create mode 100644 pkg/labels/types.go create mode 100644 pkg/orgs/file.go create mode 100644 pkg/orgs/types.go create mode 100644 pkg/orgs/types_test.go rename pkg/sigs/{sigs.go => file.go} (100%) diff --git a/Makefile b/Makefile index 663c0daa..ea5491a6 100644 --- a/Makefile +++ b/Makefile @@ -1,4 +1,5 @@ generate: + go run ./validators/cmd/sigs --dry-run=false go run ./generators/cmd/sigs validate-sigs: diff --git a/generators/cmd/sigs/sig-list.gomd b/generators/cmd/sigs/sig-list.gomd index 22005e81..793bffe5 100644 --- a/generators/cmd/sigs/sig-list.gomd +++ b/generators/cmd/sigs/sig-list.gomd @@ -19,7 +19,7 @@ */ -}} {{- /* gotype: kubevirt.io/community/generators/cmd/sigs.SigListTemplateData */ -}} -{{ define "group" }}|[{{ .Name }}]({{ .Dir }}/charter.md) |{{ if .Label }}[{{ .Label }}](https://github.com/kubevirt/kubevirt/labels/{{ .Label }}){{ end }} | {{ if .Leadership }}
    {{ range $index2, $chair := .Leadership.Chairs }}
  1. [{{ $chair.Name }}](https://github.com/{{ $chair.Github }}), {{ $chair.Company }}
  2. {{ end }}
{{ end }} |{{ if .Contact }}[Slack]({{ .Contact.Slack}})
[Mailing List]({{ .Contact.MailingList }}){{ end }} |
    {{ range $index3, $meeting := .Meetings }}
  • {{ $meeting.Description }}: [ {{ $meeting.Day }} at {{ $meeting.Time }} {{ $meeting.TZ }} ({{ $meeting.Frequency }}) ]({{ $meeting.URL }})
  • {{ end }}
|{{ end }} +{{ define "group" }}|{{ if .Dir }}[{{ end }}{{ .Name }}{{ if .Dir }}]({{ .Dir }}/charter.md){{ end }} |{{ if .Label }}[{{ .Label }}](https://github.com/kubevirt/kubevirt/labels/{{ .Label }}){{ end }} |{{ if .Leadership }}
    {{ range $index2, $chair := .Leadership.Chairs }}
  1. [{{ $chair.Name }}](https://github.com/{{ $chair.Github }}), {{ $chair.Company }}
  2. {{ end }}
{{ end }} |{{ if .Contact }}[Slack]({{ .Contact.Slack}})
[Mailing List]({{ .Contact.MailingList }}){{ end }} |
    {{ range $index3, $meeting := .Meetings }}
  • {{ $meeting.Description }}: [ {{ $meeting.Day }} at {{ $meeting.Time }} {{ $meeting.TZ }} ({{ $meeting.Frequency }}) ]({{ $meeting.URL }})
  • {{ end }}
|{{ end }}