From 3cfbf8a6faf6211e3137dae5ebc8432f47496122 Mon Sep 17 00:00:00 2001 From: Tedi Mitiku Date: Sat, 18 Jan 2025 16:12:06 -0500 Subject: [PATCH 1/2] don't get historical enclaves for service logs completion --- .../highlevel/enclave_id_arg/enclave_id_arg.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/cli/command_framework/highlevel/enclave_id_arg/enclave_id_arg.go b/cli/cli/command_framework/highlevel/enclave_id_arg/enclave_id_arg.go index 4363bacdc4..6f943a8608 100644 --- a/cli/cli/command_framework/highlevel/enclave_id_arg/enclave_id_arg.go +++ b/cli/cli/command_framework/highlevel/enclave_id_arg/enclave_id_arg.go @@ -55,7 +55,7 @@ func NewHistoricalEnclaveIdentifiersArgWithValidationDisabled( DefaultValue: "", IsGreedy: isGreedy, ValidationFunc: noValidationFunc, - ArgCompletionProvider: args.NewManualCompletionsProvider(getExistingAndHistoricalCompletions), + ArgCompletionProvider: args.NewManualCompletionsProvider(getCompletions), } } From f19ed6630fd7917426b49d06d68a5b7c02e9f62a Mon Sep 17 00:00:00 2001 From: Tedi Mitiku Date: Sat, 18 Jan 2025 16:20:59 -0500 Subject: [PATCH 2/2] remove unused func --- .../enclave_id_arg/enclave_id_arg.go | 21 ------------------- 1 file changed, 21 deletions(-) diff --git a/cli/cli/command_framework/highlevel/enclave_id_arg/enclave_id_arg.go b/cli/cli/command_framework/highlevel/enclave_id_arg/enclave_id_arg.go index 6f943a8608..4bf1b3531a 100644 --- a/cli/cli/command_framework/highlevel/enclave_id_arg/enclave_id_arg.go +++ b/cli/cli/command_framework/highlevel/enclave_id_arg/enclave_id_arg.go @@ -89,27 +89,6 @@ func getCompletions(ctx context.Context, flags *flags.ParsedFlags, previousArgs return enclaveNames, nil } -// Make best-effort attempt to get enclave names -func getExistingAndHistoricalCompletions(ctx context.Context, _ *flags.ParsedFlags, _ *args.ParsedArgs) ([]string, error) { - kurtosisCtx, err := kurtosis_context.NewKurtosisContextFromLocalEngine() - if err != nil { - return nil, stacktrace.Propagate( - err, - "An error occurred connecting to the Kurtosis engine for retrieving the names for tab completion", - ) - } - - enclaveIdentifiers, err := kurtosisCtx.GetExistingAndHistoricalEnclaveIdentifiers(ctx) - if err != nil { - return nil, stacktrace.Propagate( - err, - "An error occurred getting the enclave identifiers", - ) - } - - return enclaveIdentifiers.GetOrderedListOfNames(), nil -} - // Create a validation function using the previously-created func getValidationFunc(argKey string, _ string, isGreedy bool) func(context.Context, *flags.ParsedFlags, *args.ParsedArgs) error { return func(ctx context.Context, flags *flags.ParsedFlags, args *args.ParsedArgs) error {