Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting images does not fully respect tolerance and units #54

Open
kuwisdelu opened this issue Dec 4, 2024 · 0 comments
Open

Plotting images does not fully respect tolerance and units #54

kuwisdelu opened this issue Dec 4, 2024 · 0 comments
Labels

Comments

@kuwisdelu
Copy link
Owner

Currently, tolerance and units are only used to process the matched m/z features for creating the image. They are not passed to features() to perform the initial matching, which leads to confusing errors when the feature is not found despite using a larger tolerance.

It should be fine to simply pass tolerance and units to features() -- are there any unforeseen issues this could cause?

In addition, we may need to print more digits on the error and warning messages. Switch to using format()?

@kuwisdelu kuwisdelu added the bug label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant