Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles do not get applied on rows with no data #92

Open
kevmo314 opened this issue Jul 18, 2020 · 3 comments
Open

Styles do not get applied on rows with no data #92

kevmo314 opened this issue Jul 18, 2020 · 3 comments

Comments

@kevmo314
Copy link
Collaborator

No description provided.

@vaebhav
Copy link

vaebhav commented Aug 14, 2020

Hi @kevmo314 ,

I would like to take this up,

I have been using the module for its simplicity.

Would like to contribute my part.

I m naive and a beginner towards open source contribution , if u can help me with some pointers on the issue , i ll gladly take this up

@kevmo314
Copy link
Collaborator Author

Hey @vaebhav thanks for the offer! I believe the gist of the problem is PyExcelerate doesn't generate cell data for rows with no data (intentionally) here: https://github.com/kz26/PyExcelerate/blob/dev/pyexcelerate/Worksheet.py#L352

This doesn't work when there are styles applied. I think we can change the cell style assignment to assign an empty string to the cell if there's no data. The tricky part about this issue is solving it in a way that Excel accepts though, it can get a little difficult with row styles.

@vaebhav
Copy link

vaebhav commented Aug 15, 2020

Hi @kevmo314 , Thank you for your response.

I'll go over the function call that you have suggested , and take a stab at it. I fully dont understand the codebase for PyExcelerate , I'll walk myself through and keep you updated on the progress on this

Do you have a sample data that I can work with to test this with ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants