Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commercetools_cart_discount to support stores #500

Closed
piran-cabiri opened this issue May 29, 2024 · 1 comment · Fixed by #532
Closed

commercetools_cart_discount to support stores #500

piran-cabiri opened this issue May 29, 2024 · 1 comment · Fixed by #532
Assignees
Labels
enhancement New feature or request

Comments

@piran-cabiri
Copy link

The commercetools_cart_discount creates cart discounts, but cannot be used to assign those discounts to particular stores.

In the commercetools API the CartDiscountDraft object takes an array of stores, and there are update cart discount actions to add and remove stores.

(There are also APIs for creating and updating a cart discount within a store, but I suggest these are less useful for Terraform.)

Currently, the commercetools terraform provider ignores the stores property of the cart discount, so these can be changed manually after creation and not noticed on updates.

@piran-cabiri piran-cabiri added enhancement New feature or request triage Needs triage labels May 29, 2024
@demeyerthom demeyerthom removed the enhancement New feature or request label Jun 21, 2024
@demeyerthom
Copy link
Member

Hi @piran-cabiri thanks for reaching out!

That is indeed something we need to add. I have added this to our board, but it might take some time before I come around to it. Feel free to open a PR with the required changes if you need this quickly!

@demeyerthom demeyerthom added enhancement New feature or request and removed triage Needs triage labels Jun 21, 2024
@demeyerthom demeyerthom self-assigned this Oct 22, 2024
@demeyerthom demeyerthom linked a pull request Oct 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants