Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hideSideMenuButton property and related statement to keep integrity of menu visibility. #2035

Closed
lizable opened this issue Nov 21, 2023 · 0 comments · Fixed by #2036
Closed

Remove hideSideMenuButton property and related statement to keep integrity of menu visibility. #2035

lizable opened this issue Nov 21, 2023 · 0 comments · Fixed by #2036
Labels
effort:easy Need to understand only a specific region of codes (good first issue, easy). size:XS ~10 LoC type:refactor Refactoring current implementation. urgency:3 Must be finished within a certain time frame.

Comments

@lizable
Copy link
Contributor

lizable commented Nov 21, 2023

Main idea

Since we've been using "blocklist" in configuration to set visibility of menu in sidebar, I think it's better to remove hideSideMenuButton property, which only works for FastTrack link in the menu.

Alternative ideas

No response

Anything else?

No response
@lizable lizable added effort:easy Need to understand only a specific region of codes (good first issue, easy). urgency:3 Must be finished within a certain time frame. type:refactor Refactoring current implementation. size:XS ~10 LoC labels Nov 21, 2023
@rapsealk rapsealk mentioned this issue Nov 21, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort:easy Need to understand only a specific region of codes (good first issue, easy). size:XS ~10 LoC type:refactor Refactoring current implementation. urgency:3 Must be finished within a certain time frame.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use blockedMenuItem to hide and show pipeline button lablup/backend.ai-webui
1 participant
@lizable