Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(objectstorage): regex #4296

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix(objectstorage): regex #4296

merged 1 commit into from
Nov 15, 2023

Conversation

xudaotutou
Copy link
Contributor

@xudaotutou xudaotutou commented Nov 14, 2023

🤖 Generated by Copilot at 6c14dc5

Summary

📦🔥🔎

This pull request adds fuzzy search functionality to the file manager component of the object storage provider in the frontend. It uses the fuse.js library as a dependency and updates the frontend/pnpm-lock.yaml and frontend/providers/objectstorage/package.json files accordingly. It also removes some unused code and fixes a bug with the folder placeholder.

We search for the truth in the dark, using fuse.js
We burn the old code with our fiery hooks, useToast and useOssStore
We face the doom of the folder bug, and crush it with our might
We rise to the next level with Next.js, and rock the file manager night

Walkthrough

  • Add fuse.js as a dependency for fuzzy search in the object storage provider (link, link, link, link, link)
  • Update next package version from 13.5.6 to 13.6.0 and add transitive dependency @babel/core (link, link)
  • Remove unused imports and functions from FileManager.tsx and tools.ts (link, link, link, link, link)
  • Add toast and prefix hooks to FileManager.tsx for displaying messages and managing prefix state (link)
  • Filter out folder placeholder from file list in FileManager.tsx to avoid empty folder (link)
  • Prepend parent folder link to file list in FileManager.tsx if prefix is not empty (link)
  • Render fuzzy search result or original file list in FileManager.tsx based on search value (link)

@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 994
✅ Successful 321
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 672
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Nov 14, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46127ec) 65.45% compared to head (6c14dc5) 65.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4296   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c121914yu c121914yu merged commit 56772da into labring:main Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants