Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update git clone command for template provider. #4315

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Conversation

zzjin
Copy link
Collaborator

@zzjin zzjin commented Nov 17, 2023

common clone:
image

--depth=1 clone:
image

Witch have at least half bandwidth usage and space usage.

🤖[deprecated] Generated by Copilot at e221385

Summary

✨📄⚡

This pull request adds a new optional field displayStatus to the AppSpec type and the App CRD, which allows controlling the visibility of apps in the sealos dashboard. It also optimizes the git operations in the updateRepo function by fetching only the latest commit from the remote template repository.

AppSpec has new field
displayStatus for dashboard
optional, with enum

Walkthrough

  • Add DisplayStatus field to AppSpec type to control app visibility in dashboard (link, link)
  • Optimize git operations in updateRepo function to sync app templates from remote repository (link)

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Nov 17, 2023

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 1045
✅ Successful 365
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 679
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Nov 17, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e82b92f) 65.45% compared to head (96fa054) 65.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4315   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: zzjin <[email protected]>
@zzjin zzjin added this to the v5.0 milestone Nov 20, 2023
@zzjin zzjin requested review from zjy365 and removed request for zjy365 November 20, 2023 07:17
@zzjin zzjin merged commit 881e165 into labring:main Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants