Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade iterm2-zmodem #3

Open
guoquan opened this issue Apr 10, 2023 · 3 comments
Open

Upgrade iterm2-zmodem #3

guoquan opened this issue Apr 10, 2023 · 3 comments

Comments

@guoquan
Copy link

guoquan commented Apr 10, 2023

Would you mind upgrade iterm2-zmodem to use current laggardkernel/iterm2-zmodem which support homebrew prefix path?

@lance6716
Copy link

@laggardkernel Hi, I also meet this problem. Currently your script uses release v1.0.0, but laggardkernel/iterm2-zmodem@1eae347 is really helpful

And another problem is

def caveats
<<~EOS
Create triggers under Profiles -> Advanced:
Regular expression: rz waiting to receive.\*\*B0100
Action: Run Silent Coprocess
Parameters: #{HOMEBREW_PREFIX}/bin/iterm2-zmodem-send
Instant: checked
Regular expression: \*\*B00000000000000
Action: Run Silent Coprocess
Parameters: #{HOMEBREW_PREFIX}/bin/iterm2-zmodem-recv
Instant: checked
EOS
end

The output is Regular expression: rz waiting to receive.**B0100 rather than Regular expression: rz waiting to receive.\*\*B0100. Seems should escape twice.

@laggardkernel
Copy link
Owner

Just updated the formula. Have a try.

I'm afraid the commit you mentioned is not a perfect solution. It still needs human intervention to export HOMEBREW_PREFIX manually. @lance6716

@lance6716
Copy link

Thanks. Maybe an automatic way is to let the two scripts have a placeholder, and replace the placeholder with HOMEBREW_PREFIX when install it.

And I found https://iterm2.com/python-api/profile.html and https://github.com/gnachman/iTerm2/blob/320e08181342c1063506d5bba89d4973ac60fb99/api/library/python/iterm2/iterm2/triggers.py#L79 maybe the manually "Create triggers under Profiles" action can also be done automatically.

I will help at my spare time 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants