Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] #3

Open
l1fe opened this issue Oct 23, 2019 · 2 comments
Open

[BUG] #3

l1fe opened this issue Oct 23, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@l1fe
Copy link

l1fe commented Oct 23, 2019

Describe the bug

When running pod install, I get the following error:

The Swift pod MyFramework depends upon React, which does not define modules. To opt into those targets generating module maps (which is necessary to import them from Swift when building as static libraries), you may set use_modular_headers! globally in your Podfile, or specify :modular_headers => true for particular dependencies.

  1. How to handle this issue?
    If I follow the instruction, seems that it doesn't work:
  pod 'MyFramework',
    :path => '../node_modules/react-native-yandex-payment/ios/MyFramework.podspec',
    :modular_headers => true
  1. Why the pod uses MyFramework as a title? It looks weird to users.
  2. Is it possible to use the newer versions of Yandex SDK or this requires extra work on your end?
@l1fe l1fe added the bug Something isn't working label Oct 23, 2019
@whalemare
Copy link
Member

Hi.

  1. Try to follow instructions more carefully, because it`s requires to use next:
target 'MyApp' do

    # ... other dependencies

    pod 'MyFramework', :path => '../node_modules/react-native-yandex-payment/ios/MyFramework.podspec'

    pod 'YandexCheckoutPayments',
        :git => 'https://github.com/yandex-money/yandex-checkout-payments-swift.git',
        :tag => '2.2.0',
        :modular_headers => true

    pod 'YandexLoginSDK',
        :git => 'https://github.com/yandexmobile/yandex-login-sdk-ios',
        :tag => '2.0.2',
        :modular_headers => true
end

pre_install do |installer|
	installer.analysis_result.specifications.each do |s|
        if s.name == 'When'
            s.swift_version = '4.2'
        end
    end
end
  1. Why the pod uses MyFramework as a title? It looks weird to users.
    I change it in next release.

  2. Is it possible to use the newer versions of Yandex SDK or this requires extra work on your end?
    I think it is possible, do it in next release.

@whalemare
Copy link
Member

whalemare commented Oct 24, 2019

I create not synthetic template, that used real npm dependency, check it. (but you should add yandex shop credentials to it for work properly. Search by TODO word)
https://github.com/whalemare/react-native-yandex-payment-example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants