Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpstan fixes #4

Closed
weierophinney opened this issue Dec 31, 2019 · 5 comments
Closed

phpstan fixes #4

weierophinney opened this issue Dec 31, 2019 · 5 comments

Comments

@weierophinney
Copy link
Member

  • some fixes on PHPDoc
  • added checks on types when needed

Changed

  • Throw an exception when unable to uncompress response content
  • Relative URIs are not allowed anymore in Zend\Http\Client.
    Anyway, usage of relative URIs has no sense and no adapter can handle it.

Fixed

  • Fixed Zend\Http\Cookies::getAllCookies(Zend\Http\Cookies::COOKIE_STRING_ARRAY).
  • Fixed Zend\Http\Cookies::getAllCookies(Zend\Http\Cookies::COOKIE_STRING_CONCAT).
  • Fixed use of HTTP URIs with empty path in Request

Originally posted by @thomasvargiu at zendframework/zend-http#157

@weierophinney
Copy link
Member Author

Removing the milestone; I suspect this patch will take a bit of back and forth before it's ready, and we're otherwise ready for the 2.9.0 release. We can target 2.10.0 for this.


Originally posted by @weierophinney at zendframework/zend-http#157 (comment)

@weierophinney
Copy link
Member Author

@thomasvargiu You will need to rebase against current develop before you start applying changes.


Originally posted by @weierophinney at zendframework/zend-http#157 (comment)

@weierophinney
Copy link
Member Author

@thomasvargiu You will need to rebase against current develop before you start applying changes.

@weierophinney should I target develop branch for merge?


Originally posted by @thomasvargiu at zendframework/zend-http#157 (comment)

@weierophinney
Copy link
Member Author

Yes, please.

On Sun, Jan 13, 2019, 6:04 AM Thomas Mauro Vargiu <[email protected]
wrote:

@thomasvargiu https://github.com/thomasvargiu You will need to rebase
against current develop before you start applying changes.

@weierophinney https://github.com/weierophinney should I target develop
branch for merge?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
zendframework/zend-http#157 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABlVw0jtiMLKWbVU8T8dhB4rMJ0eWwAks5vCyDAgaJpZM4Xd9qx
.


Originally posted by @weierophinney at zendframework/zend-http#157 (comment)

@samsonasik
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants