Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] self-update from github releases not working #459

Open
4 tasks done
sergix44 opened this issue Aug 25, 2023 · 1 comment · May be fixed by laravel-zero/framework#481
Open
4 tasks done

[BUG] self-update from github releases not working #459

sergix44 opened this issue Aug 25, 2023 · 1 comment · May be fixed by laravel-zero/framework#481

Comments

@sergix44
Copy link

Basically, when trying to use the self-update configured to use the github release, you only get a 404 because it's pointing to a non existing URL:
image

  • The repository is public and accessible
  • There is a release 1.0.0 and 1.0.1
  • The updater.strategy was set according to the documentation
  • Pushed on packagist and configured for auto update

How to reproduce
@owenvoke
Copy link
Member

I can replicate the issue, it seems to be because the setPharName() method never gets called on that strategy. PRing a fix shortly. 👍🏻

@owenvoke owenvoke linked a pull request Aug 25, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: resolve Phar updater strategies owenvoke/laravel-zero-framework
2 participants
@owenvoke @sergix44