Queued Actions do not serialize models properly.

[rakishii13]

• Laravel Version: 8.40.0
• Nova Version: 3.24.0
• PHP Version: 7.4.3
• Database Driver & Version: mysql
• Operating System and Version: CentOS 7
• Browser type and version: Chrome 90
• Reproduction Repository: https://github.com/###/###

Description: Models do not properly serialize in a Queued Action that is then calling a Queued Job.

If an Action is queued that is then dispatching to a queued job through the handle() method then it will not serialize the models in a collection properly which means that the relations for that model are not shown properly or eager loaded. It seems like when the models are sent from the Action to the Job, the serialization of the models fails and there is nothing to serialize it.

Detailed steps to reproduce the issue on a fresh Nova installation:

1. Create a Queued Action

<?php

namespace App\Nova\Actions;

use App\Nova\Actions\Action;
use Illuminate\Contracts\Queue\ShouldQueue;

class QueuedAction extends Action implements ShouldQueue
{
    /**
     * Perform the action on the given models.
     *
     * @param  \Laravel\Nova\Fields\ActionFields  $fields
     * @param  \Illuminate\Support\Collection  $models
     * @return mixed
     */
    public function handle(ActionFields $fields, Collection $models)
    {
        QueuedJob::dispatch($models);
    }

    /**
     * Get the fields available on the action.
     *
     * @return array
     */
    public function fields()
    {
        return array_merge(parent::fields(), []);
    }
}

2. Create a queued Job.

namespace App;

use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Bus\Dispatchable;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Queue\SerializesModels;
use Illuminate\Support\Collection;

class QueuedJob implements ShouldQueue
{
    use Dispatchable;
    use InteractsWithQueue;
    use Queueable;
    use SerializesModels;

    public Collection $models;

    /**
     * Create a new job instance.
     *
     * @param  \Illuminate\Support\Collection  $models
     * @return void
     */
    public function __construct(Collection $models)
    {
        $this->models = $models;
    }

    /**
     * Execute the job.
     *
     * @return void
     */
    public function handle()
    {
        
    }
}

Just then dumping out the queries, you can see that there was no relations loaded for the job.

[crynobone]

1. Action uses cursor() to speed up populating actions for large resources.
2. You need to consider that Running Action will query models to QueuedAction, QueuedAction will then have to query model (and relation) again, and then QueuedJob will also need to re-query model (and relations). This is highly inefficient.

You should be able to do the following:

namespace App;

use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Bus\Dispatchable;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Queue\SerializesModels;
use Illuminate\Support\Collection;

class QueuedJob implements ShouldQueue
{
    use Dispatchable;
    use InteractsWithQueue;
    use Queueable;
    use SerializesModels;

    public Collection $models;

    /**
     * Create a new job instance.
     *
     * @param  \Illuminate\Support\Collection  $models
     * @return void
     */
    public function __construct(Collection $models)
    {
        $this->models = $models;
    }

    /**
     * Execute the job.
     *
     * @return void
     */
    public function handle()
    {
        $this->models->loadMissing('relations');
    }
}