Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show tabs which have no visible fields #6615

Closed
puzzledmonkey opened this issue Dec 17, 2024 · 1 comment
Closed

Don't show tabs which have no visible fields #6615

puzzledmonkey opened this issue Dec 17, 2024 · 1 comment
Labels
bug Verified bug by the Nova team fix incoming A fix is in review
Milestone

Comments

@puzzledmonkey
Copy link

puzzledmonkey commented Dec 17, 2024

  • Laravel Version: 11
  • Nova Version: 5.0.2
  • PHP Version: 8.3
  • Database Driver & Version: n/a
  • Operating System and Version: n/a
  • Browser type and version: n/a
  • Reproduction Repository: n/a

Description:

Tabs which don't contain any visible fields should be hidden automatically

Detailed steps to reproduce the issue on a fresh Nova installation:

Thanks for implementing tabs! However, when using tabs with dependsOn, it's sometimes the case that a tab will have no currently-visible fields in it. Is it possible to hide the tab in this case (or provide a hideWhenEmpty() or similar)?

@crynobone crynobone added this to the 5.1.x milestone Dec 17, 2024
@crynobone crynobone added pending Issues that are pending triage bug Verified bug by the Nova team fix incoming A fix is in review and removed pending Issues that are pending triage labels Dec 19, 2024
@crynobone crynobone modified the milestones: 5.1.x, 5.0.x Dec 23, 2024
@crynobone crynobone removed the fix incoming A fix is in review label Dec 23, 2024
@crynobone crynobone modified the milestones: 5.0.x, 5.1.x Dec 23, 2024
@crynobone crynobone added the fix incoming A fix is in review label Dec 27, 2024
Copy link

github-actions bot commented Jan 2, 2025

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified bug by the Nova team fix incoming A fix is in review
Projects
None yet
Development

No branches or pull requests

2 participants