From 227a56d08f3f44e91b7332225df04cf296c35a68 Mon Sep 17 00:00:00 2001
From: alexstrel <astrel@fnal.gov>
Date: Mon, 4 Dec 2023 16:41:05 -0600
Subject: [PATCH] using container of fields, instead of pointers

---
 lib/make_4d_prop_quda.cpp | 27 ++++++++++++---------------
 1 file changed, 12 insertions(+), 15 deletions(-)

diff --git a/lib/make_4d_prop_quda.cpp b/lib/make_4d_prop_quda.cpp
index f958f0523b..bca668b8d5 100644
--- a/lib/make_4d_prop_quda.cpp
+++ b/lib/make_4d_prop_quda.cpp
@@ -29,22 +29,22 @@ namespace quda
     void *VLs2 = in.data<char*>() + (Ls / 2) * vol4D * spin * col * data_size;
 
     // Create wrappers around the (Ls/2)-1 and Ls/2 4D fields
-    std::vector<ColorSpinorField *> Ls2m1;
+    std::vector<ColorSpinorField> Ls2m1;
     param4D.v = VLs2m1;
     param4D.create = QUDA_REFERENCE_FIELD_CREATE;
-    Ls2m1.push_back(ColorSpinorField::Create(param4D));
+    Ls2m1.push_back(ColorSpinorField(param4D));
 
-    std::vector<ColorSpinorField *> Ls2;
+    std::vector<ColorSpinorField> Ls2;
     param4D.v = VLs2;
     param4D.create = QUDA_REFERENCE_FIELD_CREATE;
-    Ls2.push_back(ColorSpinorField::Create(param4D));
+    Ls2.push_back(ColorSpinorField(param4D));
 
     // Ensure out is zeroed
     qudaMemsetAsync(out.data(), 0, vol4D * spin * col * data_size, device::get_default_stream());
 
     // out(x) = P_L L0(x) + P_R Lsm1(x)
-    ApplyChiralProj(out, *Ls2m1[0], 1);
-    ApplyChiralProj(out, *Ls2[0], -1);
+    ApplyChiralProj(out, Ls2m1[0], 1);
+    ApplyChiralProj(out, Ls2[0], -1);
   }
 
   void make4DChiralProp(ColorSpinorField &out, ColorSpinorField &in)
@@ -65,24 +65,21 @@ namespace quda
     void *VLsm1 = in.data<char*>() + (Ls - 1) * vol4D * spin * col * data_size;
 
     // Create wrappers around the 0 and Ls-1 4D fields
-    std::vector<ColorSpinorField *> L0;
+    std::vector<ColorSpinorField> L0;
     param4D.v = V0;
     param4D.create = QUDA_REFERENCE_FIELD_CREATE;
-    L0.push_back(ColorSpinorField::Create(param4D));
+    L0.push_back(ColorSpinorField(param4D));
 
-    std::vector<ColorSpinorField *> Lsm1;
+    std::vector<ColorSpinorField> Lsm1;
     param4D.v = VLsm1;
     param4D.create = QUDA_REFERENCE_FIELD_CREATE;
-    Lsm1.push_back(ColorSpinorField::Create(param4D));
+    Lsm1.push_back(ColorSpinorField(param4D));
 
     // Ensure out is zeroed
     qudaMemsetAsync(out.data(), 0, vol4D * spin * col * data_size, device::get_default_stream());
 
     // out(x) = P_L L0(x) + P_R Lsm1(x)
-    ApplyChiralProj(out, *L0[0], -1);
-    ApplyChiralProj(out, *Lsm1[0], 1);
-    
-    delete Lsm1[0];
-    delete L0[0];
+    ApplyChiralProj(out, L0[0], -1);
+    ApplyChiralProj(out, Lsm1[0], 1);
   }
 } // namespace quda