Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input validation for solver-related parameters #148

Open
1 task done
AlessandroPierro opened this issue Dec 9, 2022 · 2 comments
Open
1 task done

Input validation for solver-related parameters #148

AlessandroPierro opened this issue Dec 9, 2022 · 2 comments
Assignees
@AlessandroPierro
Labels
1-feature New feature or request 2-not-important/urgent

Comments

@AlessandroPierro
Copy link
Collaborator

AlessandroPierro commented Dec 9, 2022 •
edited
Loading

User Story

As a developer/user, I want to be warned if I use wrong/non-existent parameters when configuring the solver.

I'm submitting a ...

  • feature request

Condition of satisfaction

  • SolverConfig checks parameters types and for invalid combinations (e.g., probe time/energy on CPU backend)
  • SolverConfig checks hyperparameters existence, type consistency and domain
@mathisrichter mathisrichter added the 0-needs-review Has to be reviewed. label Jan 9, 2023
@GaboFGuerra
Copy link
Collaborator

These should not only be updated on the tests, the solver needs to also assert only valid fields for hyperparameter are allowed

@AlessandroPierro
Copy link
Collaborator Author

These should not only be updated on the tests, the solver needs to also assert only valid fields for hyperparameter are allowed

Agree, we need to design a system to do that since different neuron models accept different hyperparameters.

@AlessandroPierro AlessandroPierro added 1-feature New feature or request and removed 0-needs-review Has to be reviewed. labels Jan 12, 2023
@AlessandroPierro AlessandroPierro changed the title Update OptimizationSolver to use new hyperparameters settings Add input checking for OptimizationSolver hyperparameters Jan 16, 2023
@GaboFGuerra GaboFGuerra added this to the Lava-optimization v0.2.4 milestone Jan 16, 2023
@AlessandroPierro AlessandroPierro linked a pull request Jan 17, 2023 that will close this issue
Enable tracking of cost value through runtime and retrieval as raw data and plot. #159
Closed
9 tasks
@GaboFGuerra GaboFGuerra changed the title Add input checking for OptimizationSolver hyperparameters OptimizationSolver checks hyperparameter input values Jan 20, 2023
@AlessandroPierro AlessandroPierro changed the title OptimizationSolver checks hyperparameter input values Input validation for solver-related parameters Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlessandroPierro AlessandroPierro

Labels
1-feature New feature or request 2-not-important/urgent
Projects
None yet
Milestone
No milestone
4 participants
@mathisrichter @AlessandroPierro @GaboFGuerra @phstratmann