Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect order of inherited parameters in the configuration panel #421

Open
AntoineGautier opened this issue Jan 6, 2025 · 0 comments
Open
Assignees
Labels
bug Something isn't working Top Priority Top of the Priority List

Comments

@AntoineGautier
Copy link
Collaborator

Parameters which are declared in a base class and which are not modified in derived classes appear after parameters which are declared in derived classes.
This is the opposite of what Modelica tools do.
The reason is that

Note that the rationale behind iterating over treeList is to select the latest parameter modification in the inheritance tree, see https://github.com/lbl-srg/ctrl-flow-dev/blob/main/client/src/interpreter/interpreter.ts#L494-L501
Therefore, simply changing the order of treeList is probably not the solution to this issue as it may result in missing parameter overrides.

The current production version doesn't exhibit this issue because the VAV templates don't have exposed parameter declared in base classes and not modified in derived classes.

@AntoineGautier AntoineGautier added the bug Something isn't working label Jan 6, 2025
AntoineGautier added a commit to AntoineGautier/ctrl-flow-dev that referenced this issue Jan 6, 2025
- The elements from the parent class are appended as before, see lbl-srg#421
@AntoineGautier AntoineGautier added the Top Priority Top of the Priority List label Jan 7, 2025
@AntoineGautier AntoineGautier self-assigned this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Top Priority Top of the Priority List
Projects
None yet
Development

No branches or pull requests

1 participant