Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove meta results for README proof_wanted link #1112

Merged

Conversation

mehbark
Copy link
Contributor

@mehbark mehbark commented Feb 1, 2025

Currently, the proof_wanted link brings up two results relating to the implementation and testing of proof_wanted. Adding NOT path:/proof_?wanted/ prevents this, making the link marginally more useful.

@mehbark
Copy link
Contributor Author

mehbark commented Feb 1, 2025

awaiting-review

@github-actions github-actions bot added the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Feb 1, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Feb 1, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Feb 1, 2025

Mathlib CI status (docs):

@fgdorais
Copy link
Collaborator

fgdorais commented Feb 1, 2025

I think something like ^proof_wanted restricts to start of line.

It's probably more useful and reliable to generate a json file (say) from the proof_wanted command data directly.

@mehbark
Copy link
Contributor Author

mehbark commented Feb 1, 2025

awaiting-author

@github-actions github-actions bot added awaiting-author Waiting for PR author to address issues and removed awaiting-review This PR is ready for review; the author thinks it is ready to be merged. labels Feb 1, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Feb 1, 2025
@mehbark
Copy link
Contributor Author

mehbark commented Feb 1, 2025

I like the idea of generating a markdown file with links to specific lines, but I want to avoid any complications for maintainers. (E.g., the file might cause merge conflicts.) Anchoring to the start of the line removes all (current) false positives, so I think this is a decent improvement. Thank you for your help!

@mehbark
Copy link
Contributor Author

mehbark commented Feb 1, 2025

awaiting-review

@github-actions github-actions bot added awaiting-review This PR is ready for review; the author thinks it is ready to be merged. and removed awaiting-author Waiting for PR author to address issues labels Feb 1, 2025
@fgdorais fgdorais added this pull request to the merge queue Feb 1, 2025
Merged via the queue into leanprover-community:main with commit 43dc9fd Feb 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review This PR is ready for review; the author thinks it is ready to be merged. builds-mathlib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants