Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GUI option for client side sound cooldown changing in the lobby #106

Open
Danghorx opened this issue Aug 7, 2023 · 9 comments
Open
Labels
gui UI issues

Comments

@Danghorx
Copy link

Danghorx commented Aug 7, 2023

The sound cooldown is hidden in the registry and not easy accessible or visible for everyone. There is also no hint ingame where to find this stuff.

@maxmitti
Copy link
Member

maxmitti commented Aug 8, 2023

Any suggestions where and how to add this?
Ingame settings are already quite full.
Also, it seems to be quite an advanced setting so it should not distract from the more important stuff.

@Danghorx
Copy link
Author

Danghorx commented Aug 8, 2023

Add it under the Options Tab in the lobby. There is room and you can scroll. What do you mean with how? Code or UI? copy the settings for the controlrate where you can select 1 to 9 or 0 to 9.

In the main menu it could be under audio under the big box or over it. Sound is empty compared to grafic.
https://i.imgur.com/B77WBXQ.png

@maxmitti
Copy link
Member

maxmitti commented Aug 9, 2023

With how I mean the UI.
Like the control rate it would be a dropdown?
I am wondering whether a different control would be better.
A number input field could also be an option. Or maybe a slider?
Also how should we label it? Do you have a better idea than “Cooldown for /sound”?

I am not too fond of the lobby suggestion.
So far the lobby options section only contains network and team related settings for the current lobby.
Maybe we should create some kind of sections within the lobby options?

Btw, for future posts: You can attach files (screenshots) directly to the comment.

@Danghorx
Copy link
Author

Danghorx commented Aug 9, 2023

Dropdown would be simple but the input field is maybe more flexible. Probably nice to have for future settings.
Tab: Lobby:
Client Soundcooldown

I think the best option would be to make a new tab for ingame and lobby. So you can differentiate more. Maybe there will be more options that will be added like a playercount (1-4) mapsize adjustment.

@Somebodyisnobody
Copy link
Contributor

But let's set the cooldown to 0 again as default so a user can set his own limit if he wants to do. Otherwise this silly 5 seconds limit will be there forever.

@Fulgen301
Copy link
Member

If the user can set their own limit, the cooldown can stay at 5 as well.

@Somebodyisnobody
Copy link
Contributor

New users will not know about this feature and there is no message thrown on a sender that some clients will not receive the sound. So if a user if being bothered by sound spamming he will search in the options and cna set his own limit on demand.

@Danghorx
Copy link
Author

I think the poll in the discord-server is "finished" after 1,5 months: https://i.imgur.com/CE0kKgp.png

@Somebodyisnobody
Copy link
Contributor

@Fulgen301 can we close this? You mentioned the change in https://clonkspot.org/blog/2023/11/01/legacyclonk-4-9-10-15-359/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gui UI issues
Projects
None yet
Development

No branches or pull requests

4 participants