Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask if scenario should be started as network game when opeing c4Scenario file #86

Open
Somebodyisnobody opened this issue Apr 24, 2022 · 8 comments

Comments

@Somebodyisnobody
Copy link
Contributor

When double clicking on a .c4s file clonk starts the scenario without network as singleplayer session with currently activated players.
I suggest to ask the user over a dialog wether

  1. the game should start in network mode and a lobby should be opened or
  2. the game should be started in singleplayer / splitscreen without network players.
@Fulgen301
Copy link
Member

This isn't an engine issue, but an issue of starting the engine with the correct arguments, which would require multiple explorer shell entries.

However, Windows 11's new context menu sucks with them.

@Somebodyisnobody
Copy link
Contributor Author

Somebodyisnobody commented Apr 26, 2022

I am aware that it depends on which arguments are delivered. But I see this as bad user experience when the user needs to open a command line to start his scenario. The concept /network etc. is in the responsibility of the engine. So I address this to the engine. It's a feature request to build in such a dialog:
Dialog


However, Windows 11's new context menu sucks with them.

👍

@maxmitti
Copy link
Member

What if opening a scenario via the shell just launches it with /lobby /nosignup?
Technically its always a network game then, but it does not really make much of a difference anyway.
The benefit of the approach is that the user can then choose to turn on masterserver registration as usual from within the lobby, if desired, or just start the game without registering with the masterserver, while also being able to adjust which players should join locally.

@Somebodyisnobody
Copy link
Contributor Author

Somebodyisnobody commented Apr 26, 2022

I'm just talking about displaying the dialig if clonk.exe is called with the c4Scenario as only argument. That's the case when double clicking on it. Workflow idea is following:

  • Show the Dialog
    • -> Network
      • Start with same setting as if the user had started the scenario via main menu -> start network game -> new game -> ...
    • -> Standalone
      • Start with same settings as if the user had started the scenario via main menu -> start game -> ...

I don't want to change the behaviour if the user starts a cli and explicitly says clonk.exe foo.c4s /lobby /nosignup. It's just about the cmdline clonk.exe foo.c4s

@Somebodyisnobody
Copy link
Contributor Author

And I would like to give a concrete use case: scenarios that are not in the clonk folder, but e.g. in the download directory, because you have to quickly host the hastily downloaded scenario from ccan.de, as the network code at the other host is once again causing problems.

(Problems from a friend 😉)

@maxmitti
Copy link
Member

I'm just talking about displaying the dialig if clonk.exe is called with the c4Scenario as only argument. That's the case when double clicking on it.

Yes, that’s basically what I am talking about. Although I thought that the file association can include arguments. And in that case I would specify the arguments there as /nosignup /lobby.

@Somebodyisnobody
Copy link
Contributor Author

So you mean the file extention association in the windows registry for example? And instead a dialog there's always a lobby without masterserver registration opened?
Yeah that would be an option but nevertheless it's a network game. The game is still reachable from local network maybe with runtimejoin. In the most cases it will not be an issue but in my mind it's just a workaround. On the other hand a positive aspect is that the user can choose his players.

I would be okay with both options

@Somebodyisnobody
Copy link
Contributor Author

@Fulgen301 is working on this at https://github.com/legacyclonk/LegacyClonk/tree/shell which would also solve the issue at it's best way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants