Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this in active development? #146

Open
testavenger opened this issue Sep 17, 2022 · 6 comments
Open

Is this in active development? #146

testavenger opened this issue Sep 17, 2022 · 6 comments

Comments

@testavenger
Copy link

No description provided.

@macintoshhelper
Copy link
Contributor

macintoshhelper commented Oct 3, 2022

Hi, you can check the git history; there haven’t been any new features/major code changes in a while, I believe the repository is more in maintenance mode with PRs being accepted for fixes or new platforms.

It’s intended to be quite a minimalist project and still works fine. I’m working on a sort of fork/evolution to this project over here: https://github.com/elemental-design/react-platform

react-native-web support appears to be broken currently though with the latest version due to createStyleResolver.js being removed: necolas/react-native-web@b27c982#diff-40578f626041a46abbd28a6414da8ace7a395d2039c00d3646368f177e457160 . I may take a look at this and contribute a fix later.

@badsyntax
Copy link

I've added a PR to remove Stylesheet.resolve: #148

@nilooy
Copy link

nilooy commented Mar 25, 2023

can we prioritise the merge of the pr mentioned above please? the library seems to be non functional for react-native-web without that.

@macintoshhelper
Copy link
Contributor

macintoshhelper commented Mar 25, 2023

@nilooy

I’ve added a comment to the PR re backwards compatibility. If this is a blocker for you and there’s no feedback from any maintainers re a potential merge, I’d be happy to copy the PR over to my fork and publish the updated fork to npm.

@nilooy
Copy link

nilooy commented Mar 25, 2023

@macintoshhelper that will be amazing, i was already copying it with typescript support, if you can do the copy, that will help a lot.

@nilooy
Copy link

nilooy commented Mar 29, 2023

i tried with local clone of the package, but if i apply #148 changes to fix the issue, then no styling worked on primitive for web.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants