Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about scrollview? #70

Closed
ahmedlhanafy opened this issue Jun 20, 2017 · 5 comments
Closed

What about scrollview? #70

ahmedlhanafy opened this issue Jun 20, 2017 · 5 comments

Comments

@ahmedlhanafy
Copy link

I feel like ScrollView is an essential part of these primitives, I can't remember any app that I built without it.

@ekryski
Copy link

ekryski commented Jul 10, 2017

My initial reaction was like "naaaaah"... but after sleeping on it I think you are right @ahmedlhanafy! It's not really possible to create a ScrollView or PanView with the current primitives.

For web it's really just a plain view with style props set for overflow visibility. For React Native you can't just use a View unfortunately.

Some time ago I created an abstraction where you could do <View scrollable></View> where under the covers if that prop was present it would render a React Native ScrollView. I think that same pattern could be applied here.

@necolas
Copy link

necolas commented Jul 10, 2017

For web it's really just a plain view with style props set for overflow visibility

It's more than that: https://github.com/necolas/react-native-web/tree/master/src/components/ScrollView

@ekryski
Copy link

ekryski commented Jul 10, 2017

@necolas totally right. I have looked through all your source on the weekend. Didn't mean to trivialize. It's definitely not "just a view with styles" in order to have API compatibility. My bad... thanks for the correction.

@dwicao
Copy link

dwicao commented Sep 21, 2017

I created better primitives with support TextInput and FlatList
Also, it's not use react-native-web package
So you can use latest react v16+ and react-native v0.48+
Take a look the repo https://github.com/dwicao/react-universal-rendering

@mathieudutour
Copy link
Collaborator

see #54 for the discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants