Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Touchable to Pressable? #76

Open
ekryski opened this issue Jul 10, 2017 · 3 comments
Open

Rename Touchable to Pressable? #76

ekryski opened this issue Jul 10, 2017 · 3 comments
Labels
question

Comments

@ekryski
Copy link

ekryski commented Jul 10, 2017

This might be just semantics but since Touchable implements onPress and various of "press" methods, maybe it makes more sense for it to be called Pressable?
@MoOx
Copy link

MoOx commented Jul 10, 2017

Not sold on this.
Touchable could have onTouchStart, onTouchEnd etc. onPress is like "onTouch" but without thinking about start/end. Imo it's better to keep it this way.

@ekryski
Copy link
Author

ekryski commented Jul 10, 2017

Yeah, I'm kind of on the fence on this as well. It seems like a bit of a "make work" project purely for semantics but I did hear @lelandrichardson mention it on a recent podcast so thought I would kick up an issue.

@jcampbell05
Copy link

Should be intractable if anything :) or button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MoOx @ekryski @jcampbell05 @mathieudutour