Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RenderingBuffer from the API #283

Closed
cecilios opened this issue Dec 30, 2020 · 2 comments · Fixed by #290
Closed

Remove RenderingBuffer from the API #283

cecilios opened this issue Dec 30, 2020 · 2 comments · Fixed by #290

Comments

@cecilios
Copy link
Member

The conversation in #282 suggests that, probably, the RenderingBuffer object should be a Lomse internal object, and any application using Lomse should just pass a ptr. to the image buffer and its size. The stride value should be something computed by Lomse as it has information for doing it.

I have to study this modification. Any comments and ideas about this and about any other possible changes to improve the API for rendering scores are welcome!
@cecilios cecilios mentioned this issue Dec 30, 2020
Closed
@ffAudio
Copy link
Contributor

ffAudio commented Dec 31, 2020

I wouldn't remove the option completely to supply a stride. It allows to draw in a sub area of the bitmap.

@cecilios
Copy link
Member Author

cecilios commented Dec 31, 2020 •
edited
Loading

Very good point! Thank you.
It has also given me a clue as to how to do solve #124 ! Great!

cecilios added a commit to cecilios/lomse that referenced this issue Jan 9, 2021
@cecilios
lenmus#283 WIP - code, tutorials and samples updated
e8c19cb
@cecilios cecilios mentioned this issue Jan 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove RenderingBuffer from the API cecilios/lomse
2 participants
@cecilios @ffAudio